ci: add timeout-minutes to echidna-fuzz rate-limit-check job#89
Merged
Conversation
The only steps-based job in the workflow set lacking a timeout bound. Closes the one real `missing_timeout_minutes` gap (the other Hypatia flags are caller workflows where timeout-minutes is invalid). Tracker: hyperpolymath/echidna#238 https://claude.ai/code/session_01UAqDQaMwpUqWHUSZekGZWv
🔍 Hypatia Security ScanFindings: 75 issues detected
View findings[
{
"reason": "Stale AI task file -- delete or move to docs/",
"type": "stale",
"file": "SONNET-TASKS.md",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Workflow executes remote script directly (curl/wget piped to shell). Download, verify checksum/signature, then execute.",
"type": "download_then_run",
"file": "echidnabot.yml",
"action": "verify_download_integrity",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in scorecard-enforcer.yml",
"type": "scorecard_publish_with_run_step",
"file": "scorecard-enforcer.yml",
"action": "split_scorecard_publish_job",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in instant-sync.yml",
"type": "secret_action_without_presence_gate",
"file": "instant-sync.yml",
"action": "peter-evans/repository-dispatch",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in codeql.yml",
"type": "codeql_missing_actions_language",
"file": "codeql.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Admitted leaves proof hole (1 occurrences, CWE-704)",
"type": "admitted",
"file": "/home/runner/work/echidnabot/echidnabot/proofs/coq/admitted_stub.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "sorry leaves proof hole (1 occurrences, CWE-704)",
"type": "sorry",
"file": "/home/runner/work/echidnabot/echidnabot/proofs/lean/sorry_stub.lean",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "expect() in hot path (1 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/echidnabot/echidnabot/src/api/rate_limit.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "expect() in hot path (1 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/echidnabot/echidnabot/src/dispatcher/echidna_client.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "expect() in hot path (1 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/echidnabot/echidnabot/src/scheduler/job_queue.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the one genuine
missing_timeout_minutesgap in echidnabot's workflow set (from the Hypatia scan on #86 / checkpoint echidna#238).What
Adds
timeout-minutes: 5to therate-limit-checkjob in.github/workflows/echidna-fuzz.yml— the only steps-based (runs-on) job across all 29 echidnabot workflows that lacked a timeout bound. One-line, pure insertion; YAML re-validated.Why the other Hypatia "missing_timeout_minutes" flags aren't fixed here
They target caller workflows (
codeql,governance,hypatia-scan,mirror,rust-ci,scorecard,secret-scanner) whose jobs useuses:to call reusable workflows.timeout-minutesis invalid on auses:job, so those flags are false-positives — noted in #88, not actionable.Draft until reviewed.
https://claude.ai/code/session_01UAqDQaMwpUqWHUSZekGZWv
Generated by Claude Code