Repository navigation
Remove SandboxRuntimeConfig - #1975
Merged
ludfjig merged 1 commit intoOct 22, 2026
Merged
Conversation
ludfjig
added
the
kind/refactor
Each field moves to the place that already owns its data: * debug_info and guest_core_dump are read from SandboxConfiguration. * The crashdump entry point is read from the memory manager, which restore already updates. * The guest binary path is dropped. Core dumps report <unknown> as the process name for every sandbox, as snapshot sandboxes already did. Sandbox setup and restore no longer need crashdump or gdb plumbing. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
remove-sandbox-runtime-config
branch
from
October 22, 2026 17:34
f929ea4 to
ae8bd5c
Compare
Benchmark ResultsMeasured commit: kvm / amd (Linux) (➖ stable)No benchmark improved or regressed. Benchmark Resultsfunction_call_codec
payload_allocation
sandboxes
slot_pool
snapshot_files
virtq_readonly
virtq_readwrite
kvm / intel (Linux) (➖ stable)No benchmark improved or regressed. Benchmark Resultsfunction_call_codec
payload_allocation
sandboxes
slot_pool
snapshot_files
virtq_readonly
virtq_readwrite
mshv3 / amd (Linux) (➖ stable)No benchmark improved or regressed. Benchmark Resultsfunction_call_codec
payload_allocation
sandboxes
slot_pool
snapshot_files
virtq_readonly
virtq_readwrite
mshv3 / intel (Linux) (➖ stable)No benchmark improved or regressed. Benchmark Resultsfunction_call_codec
payload_allocation
sandboxes
slot_pool
snapshot_files
virtq_readonly
virtq_readwrite
hyperv-ws2025 / amd (Windows) (➖ stable)No benchmark improved or regressed. Benchmark Resultsfunction_call_codec
payload_allocation
sandboxes
slot_pool
snapshot_files
virtq_readonly
virtq_readwrite
hyperv-ws2025 / intel (Windows) (➖ stable)No benchmark improved or regressed. Benchmark Resultsfunction_call_codec
payload_allocation
sandboxes
slot_pool
snapshot_files
virtq_readonly
virtq_readwrite
Reported by |
ludfjig
marked this pull request as ready for review
October 22, 2026 18:53
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
October 22, 2026 18:53
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused refactor preserves configuration and entry-point behavior, and the intentional metadata change is documented with no blocking issues identified.
No open issues 🎉
What changed in this PR
Removes SandboxRuntimeConfig to separate per-sandbox settings from per-image state, addressing #1279.
Changes:
- Reads debugging settings from
SandboxConfigurationand the crashdump entry point from the memory manager. - Simplifies sandbox creation and restore by removing runtime-config plumbing.
- Uses
<unknown>for core-dump process metadata and documents the behavior.
| File | Description |
|---|---|
| src/hyperlight_host/src/sandbox/uninitialized.rs | Removes runtime configuration and simplifies constructors and tests. |
| src/hyperlight_host/src/sandbox/uninitialized_evolve.rs | Reads debugger settings directly from sandbox configuration. |
| src/hyperlight_host/src/sandbox/initialized.rs | Removes redundant creation and restore plumbing. |
| src/hyperlight_host/src/hypervisor/mod.rs | Updates test setup to match the simplified interface. |
| src/hyperlight_host/src/hypervisor/hyperlight_vm/x86_64.rs | Reads the crashdump entry point from the memory manager. |
| src/hyperlight_host/src/hypervisor/hyperlight_vm/mod.rs | Stores the core-dump flag without a runtime-config wrapper. |
| src/hyperlight_host/src/hypervisor/hyperlight_vm/aarch64.rs | Removes the unused runtime-config parameter. |
| src/hyperlight_host/src/hypervisor/crashdump.rs | Uses <unknown> for process name and command line. |
| docs/how-to-debug-a-hyperlight-guest.md | Explains that users must track the matching guest binary. |
| CHANGELOG.md | Records the core-dump metadata change. |
Review effort: Balanced
jsturtevant
reviewed
Oct 22, 2026
jsturtevant
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1279.
SandboxRuntimeConfigheld per-sandbox settings next to per-image state. Each field now lives with the data it belongs to:debug_infoandguest_core_dumpare read fromSandboxConfiguration.restore()already updates.<unknown>as the process name for every sandbox. Snapshot and restored sandboxes already did this since Support core dump on snapshots created from snapshot/disk #1618. The debugging docs now say dumps do not record the guest binary.Sandbox setup,
from_snapshot, andrestore()no longer need crashdump or gdb plumbing.A later improvement could link guests with a GNU build ID and report it in core dumps. That would identify the exact guest build without a path.