Repository navigation
Conversation
Decide blocked when the decision channel was full and the view was being aborted: the controller loop could be inside abortView waiting for the view to stop, and the view could be waiting to enqueue its decision. The abort and the decision waited for each other. Hand the decision to the controller in the background when the view is aborting. The decision is not dropped: MutuallyExclusiveDeliver filters a duplicate that the view changer has already delivered. Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decide blocked when the decision channel was full and the view was being aborted: the controller loop could be inside abortView waiting for the view to stop, and the view could be waiting to enqueue its decision. The abort and the decision waited for each other.
Hand the decision to the controller in the background when the view is aborting. The decision is not dropped: MutuallyExclusiveDeliver filters a duplicate that the view changer has already delivered.
#736