Repository navigation
fix: report false schemas under propertyNames - #303
Open
MohitSAGAR11 wants to merge 1 commit into
Open
MohitSAGAR11 wants to merge 1 commit into
MohitSAGAR11 wants to merge 1 commit into
Conversation
The error index stores property name locations without the "*" ("#*/foo" is indexed as "#/foo"). Keywords looked errors up that way, but boolean schemas used the location as is, so a false schema under propertyNames was treated as passing and produced no error.
Fixes hyperjump-io#302
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302
A
falseschema underpropertyNamesnow produces an error.The error index stores property name locations without the
*(#*/foois indexed as#/foo). Keywords already looked errors up that way, but boolean schemas used the location as is, so they found nothing and were treated as passing. The star-stripped location is now computed once inevaluateSchemaand used for both.Tests
Added to
src/test-suite/tests/propertyNames.json:propertyNames falsepropertyNames with a false schema in allOfpropertyNames with a $ref to a false schemapropertyNames false in anyOf: the first alternative used to be empty.All 4 fail without the fix (24 runs across dialects).
npm test(2200 passed),npm run type-checkandnpm run lintpass.