feat(http1): support expect: 100-continue on the client - #4182
Draft
bountis wants to merge 2 commits into
Draft
Conversation
bountis
commented
Sep 3, 2026
Comment on lines
+269
to
+272
| #[cfg(feature = "client")] | ||
| if seen_continue { | ||
| self.release_continue(); | ||
| } |
Author
There was a problem hiding this comment.
Had to include this before the parse result match because otherwise the early return in the Pending arm would never flip the state and deadlock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the
Expect: 100-continueheader fully.https://www.rfc-editor.org/rfc/rfc9110.html#name-expect
This adds the missing handling logic of the header. The client didn't handle the header previously.
If there's the
Expect: 100-continueheader present the client only writes the head and parks the body.If the server returns
100 Continuethen go on and write the body.If the server returns any non-1xx response the client drops the body and closes the connection.
Empty body ignores the header completely.
Also add a configurable timer to the client, client sends the body after the timeout, only if there's a timer setup, if not then it waits indefinitely.
Closes #3833