fix(ci): onboard Renovate and move onto current action majors - #3
Merged
Merged
Conversation
Every action here was several majors behind because this repo has no Renovate config at all - nothing was ever going to bump it. checkout v4 (current v7), setup-node v4 (v7), setup-go v5 (v7), upload-artifact v4 (v7), download-artifact v4 (v8). Adding renovate.json is the actual fix; the bumps just clear the backlog it would otherwise open five PRs for. The org preset also SHA-pins actions, so Renovate will convert these tags to commit SHAs on its first run - which is why they are left as tags here rather than pinned by hand. The majors carry real breaking changes, so each was checked rather than assumed: - checkout v6+ and the artifact actions v6/v7+ need Actions Runner >= 2.329.0 / 2.327.1. The ARC scale set this repo uses reports 2.336.0. - download-artifact v5's breaking path change applies to downloads BY ID; this workflow downloads by name into an explicit path. - upload-artifact v7's direct uploads and download-artifact v8's "no longer unzips everything" are one generation and move together, which is the supported path. Splitting them is what breaks. Left alone deliberately: Swatinem/rust-cache@v2 and EmbarkStudios/cargo-deny-action@v2 are already the current major, and dtolnay/rust-toolchain@stable / taiki-e/install-action@nextest name a channel rather than a version. NOTE: release.yml only runs on a release, so those steps are not exercised until the next one. Refs hyperi-io/hyperi-ci#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo had no Renovate config at all, so nothing was ever going to bump it.
Every action was several majors behind: checkout v4 (current v7), setup-node v4
(v7), setup-go v5 (v7), upload-artifact v4 (v7), download-artifact v4 (v8).
renovate.jsonis the actual fix. The bumps just clear the backlog Renovatewould otherwise open five PRs for, and the org preset SHA-pins actions, so
Renovate converts these tags to commit SHAs on its first run.
These majors carry real breaking changes, so each was checked rather than
assumed:
/ 2.327.1. The ARC scale set this repo uses reports 2.336.0.
workflow downloads by name into an explicit path.
unzips everything) are one generation and move together, which is the
supported path. Splitting them is what breaks.
Left alone on purpose:
Swatinem/rust-cache@v2andEmbarkStudios/cargo-deny-action@v2are already the current major, anddtolnay/rust-toolchain@stable/taiki-e/install-action@nextestname achannel rather than a version.
Worth knowing:
release.ymlonly runs on a release, so those steps are notexercised until the next one.
Part of a fleet sweep - hyperi-io/hyperi-ci#100.