Repository navigation
docs: add python and rust tabs to the home page example - #89
Merged
Merged
Conversation
The home page showed only the Python example. Add a Rust tab whose code comes from a new in-memory quickstart section of embedded_query.rs, so CI compiles and runs it like the other Rust snippets.
Deploying lance-csr with
|
| Latest commit: |
8d38252
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f1517e7.lance-csr.pages.dev |
| Branch Preview URL: | https://docs-homepage-rust-tab.lance-csr.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The code example on the home page was Python only, even though lance-csr also ships as a Rust crate. Rust readers had to go to another page to see what the same query looks like in Rust.
What changed
Personrows and twoKNOWSedges, held in memory withEngineSource::Arrow, and the same[:KNOWS*1..2]query, which returns Bob and Carol.quickstartsection of theembedded_queryexample rather than in the page, so CI compiles and runs it. The tab shows only the body of the code, without itsuselines, the same way the Rust guide does.There are no API or behaviour changes. The only user-facing changes are the home page and the runnable example.
Validation
uv run --project docs --locked zensical build --strict: no issues. The built home page has both tabs and the Rust snippet.uvx typos@1.26.0 .: clean.docs/check_snippets.pyagainst a local build: passes, including the Python block inside its tab.cargo run -p lance-csr --example embedded_query: prints Bob and Carol, which matches the output comment.cargo fmt --all -- --checkandcargo clippy -p lance-csr --example embedded_query -- -D warnings: clean.🤖 Generated with Claude Code