Repository navigation
Conversation
Use catalog schemas and scoped aliases to diagnose incompatible operands before planning. Preserve numeric and temporal coercions and defer unknown types to DataFusion. Add Rust semantic and Python execution coverage. Part of #23. Implemented with assistance from Codex; runtime tests queued and benchmark validation pending.
Deploying lance-csr with
|
| Latest commit: |
1939b69
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e1450de.lance-csr.pages.dev |
| Branch Preview URL: | https://codex-issue-23-expression-ty.lance-csr.pages.dev |
prrao87
changed the base branch from
codex/issue-23-config-accessors
to
codex/issue-23-expression-types-base
October 26, 2026 16:49
prrao87
marked this pull request as ready for review
October 26, 2026 16:49
prrao87
merged commit Oct 26, 2026
628bbde
into
codex/issue-23-expression-types-base
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Uses catalog schemas and the existing semantic scopes to validate arithmetic and comparisons before execution. Errors identify the expression and operand types, surfacing as Python
ValueError. Supported numeric promotion, null operands and temporal combinations remain valid; unresolved types are left to execution rather than rejected speculatively.The Cypher guide and API reference describe the validation. Real Arrow-schema regressions cover numeric/temporal compatibility, established mismatches, alias/WITH scope propagation and nulls. This submission stacks the compatible mapping accessors; privacy and validated deserialization remain staged for the next breaking release.
Validation
Head
1939b6948792ed84eecd0914ff413da792ac2875; frozen parent96598edac33e9c8dab8bf3b0ec1324308faf589e. Focused checks and regression details record commands, results, documentation and compatibility. The release receipt pins wheel/archive identity and 16 installed tests.Both complete workloads pass unchanged goldens in memory and lazy modes. Retained first-pass geometric mean speedups are below (greater than one is faster). Per-query results and paired investigations remain in the audit archive.
Measurements use the same Apple M4 Max (16 cores, 128 GiB), macOS 26.6.2 arm64 and Python 3.13.17, with Q30 revision
6260689and IC revisionc185123. Reproduction instructions pin settings, data checksums, locks and commands. The frozen main baseline is code-identical to current main90114f3; the equivalence check also verifies clean prospective main-target merges.Individual review gates pass under the recorded repeat/controlled-investigation rules. Initial failed measurements remain intact in the audit record.
User impact
Schema-aware arithmetic/comparison validation preserves supported null/numeric/temporal coercions and rejects established mismatches with operand types and expression context. Python errors and scope propagation are tested; guides/examples are updated.
Review ledger · Current contribution guide
Audit archive: 47,675,190 bytes; SHA-256
b3486fb30a34639c830b5d49353b3838f96369f95df959ac35f85511f7f8b2de. The small current-main supplement preserves the documentation update. Original absolute paths in receipts map to included records through the archive index.Submitted by David Hughes (@stugorf), with AI Collaboration.