Repository navigation
Conversation
Parse UNION and UNION ALL as independent branches, validate matching output columns and compatible Arrow types, and preserve distinct versus bag semantics. Include all branches in query metadata and document direct Rust AST migration. Part of #20. Submitted by David Hughes (@stugorf), with AI Collaboration. Full combined validation and SF1 measurements remain pending.
Use DataFusion UNION coercion before exposing child schemas and capture the physical result schema for collection. Preserve promoted numeric types and nullable outputs regardless of branch batch arrival order. Add repeated literal and parameter-null checks for collected and streamed results. The equivalent combined CALL/UNION implementation passed 10 Rust and 88 Python focused cases. Coordinator will validate this isolated commit on the standalone UNION branch. Submitted by David Hughes (@stugorf), with AI Collaboration.
prrao87
marked this pull request as ready for review
October 26, 2026 16:49
prrao87
merged commit Oct 26, 2026
3fd230a
into
codex/issue-20-union-delivery-prerequisites
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Part of #20. Keep the tracker open for its remaining feature groups.
UNION branches have independent scopes and require matching output names, order and compatible Arrow types. UNION ALL preserves duplicates; UNION deduplicates complete rows. Branch-local ordering and pagination remain local. Numeric/null coercion and result nullability are determined before results are exposed, independent of batch arrival order.
Validation
Head
6e62a429da270649aa6877e81fc4a67df941bdc8; frozen parentccfc4fece4c1a099ab5b494f6a4533dfd03acc11. Focused checks and regression details record commands, results, documentation and compatibility. The release receipt pins wheel/archive identity and 102 installed tests.Both complete workloads pass unchanged goldens in memory and lazy modes. Retained first-pass geometric mean speedups are below (greater than one is faster). Per-query results and paired investigations remain in the audit archive.
Measurements use the same Apple M4 Max (16 cores, 128 GiB), macOS 26.6.2 arm64 and Python 3.13.17, with Q30 revision
6260689and IC revisionc185123. Reproduction instructions pin settings, data checksums, locks and commands. The frozen main baseline is code-identical to current main90114f3; the equivalence check also verifies clean prospective main-target merges.Individual review gates pass under the recorded repeat/controlled-investigation rules. Initial failed measurements remain intact in the audit record.
User impact
Branches have isolated scopes and compatible output names/counts/types. UNION deduplicates; UNION ALL retains duplicates. Parser/semantic/execution examples and supported-feature tables are updated.
Review ledger · Current contribution guide
Audit archive: 47,675,190 bytes; SHA-256
b3486fb30a34639c830b5d49353b3838f96369f95df959ac35f85511f7f8b2de. The small current-main supplement preserves the documentation update. Original absolute paths in receipts map to included records through the archive index.Submitted by David Hughes (@stugorf), with AI Collaboration.