Repository navigation
feat(python): allow an explicit query partition target - #35
Merged
prrao87 merged 2 commits intoOct 26, 2026
Merged
Conversation
Member
|
This change merged into an intermediate branch, not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Relates to #15. Keep DataFusion's existing partition/default repartition settings and add keyword-only
CypherEngine(..., target_partitions=None)for callers who measure their workload. Positive Python integers are accepted; booleans and invalid bounds are rejected. Refresh preserves the override. It controls partitions rather than threads or memory.The controlled comparison covers partitions 1, 2 and the measured host's default 16, with round-robin repartition enabled and disabled: 24 complete workload cells and 528 unchanged golden checks, followed by 60 paired repeat cells. No alternative improves both workload geometric means without per-query regressions. The setting report retains every query and the trade-off. Thirty-six wide-scan runs over 500,000 rows with 4 KiB properties also pass; failed setup/checksum attempts are preserved and excluded. No adaptive scheduler or universal speedup is introduced.
Validation
Head
7461a7774d6cdf74bbd6961efa7ec86b229fa945; frozen parent91d6b482a625b671c1e2eef923a4105331dc7ef4. Focused checks and regression details record commands, results, documentation and compatibility. The release receipt pins wheel/archive identity and 1,209 installed tests.Both complete workloads pass unchanged goldens in memory and lazy modes. Retained first-pass geometric mean speedups are below (greater than one is faster). Per-query results and paired investigations remain in the audit archive.
Measurements use the same Apple M4 Max (16 cores, 128 GiB), macOS 26.6.2 arm64 and Python 3.13.17, with Q30 revision
6260689and IC revisionc185123. Reproduction instructions pin settings, data checksums, locks and commands. The frozen main baseline is code-identical to current main90114f3; the equivalence check also verifies clean prospective main-target merges.This is a coordinated draft. Preserve its frozen-head outcomes and apply the shared corrections in the qualified integration; changing the actual target requires requalification. The accepted combined engine source is
7d2ef3e; its current-main documentation merge is5fe24cd.User impact
CypherEngine gains keyword-only target_partitions=None. Positive integers are accepted, invalid values/booleans rejected, and refresh preserves the setting. Existing defaults remain; guides, API reference, stubs and a refresh example are updated.
Review ledger · Current contribution guide
Audit archive: 47,675,190 bytes; SHA-256
b3486fb30a34639c830b5d49353b3838f96369f95df959ac35f85511f7f8b2de. The small current-main supplement preserves the documentation update. Original absolute paths in receipts map to included records through the archive index.Submitted by David Hughes (@stugorf), with AI Collaboration.