Repository navigation
feat: benchmark lance-csr 0.5.1 on the 30 queries - #34
Merged
Merged
Conversation
lance-csr 0.5.0 removes with_node_label and with_relationship, which the shared lance-graph query module calls, so the lance-csr runner would fail before running a query. Build the same mapping with lance-csr's node_table and rel_table instead, reading each relationship's endpoint node tables from its dataset name. The shared module, queries and expected answers are unchanged, and the change works on 0.3.1 as well.
Bump lance-csr from 0.3.1 to 0.5.1 and re-run both modes on mains power. All 30 queries pass in memory and lazy modes. Archive the 0.3.1 results and update the results table, heatmap and docs.
prrao87
marked this pull request as ready for review
October 31, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
lance-csr 0.5.1 is out, and the published lance-csr numbers are from 0.3.1. This updates the lance-csr columns to the current release. The other engines' results are unchanged.
This branch builds on #33, which moves the lance-csr runner to
node_tableandrel_tablebecause 0.5.0 removed the builder methods it used. Merge #33 first; this PR then shows only the version bump and new results.What changed
./run_benchmarks.sh lance_csrwriteslance-csr-0.5.1-memoryandlance-csr-0.5.1-lazyresults.Compared with 0.3.1, most queries are within run-to-run noise. The two slowest queries:
q30 is faster in both modes. Lazy-mode q27 and q28 had a few slow rounds in this run (q28 stddev 1.66 ms on a 1.93 ms min), so their means overstate them slightly.
Validation
./run_benchmarks.sh lance_csron the Apple M5 on AC power: all 30 queries pass their result assertions in both modes, with no deprecation warnings.🤖 Generated with Claude Code