Repository navigation
Fix Codex exec outcomes for content-item results - #3033
Conversation
Read the script outcome from the first text item. Preserve a single nested command exit code separately from the script outcome and keep the captured output and fallback message identity stable. Refs #3029
|
Final review (HypForge steward) at head d0b3eaf. Rating: LOW. Clean. 4 files in the codex plugin, nothing under What was checked:
Lines:
Gates:
Release note: "Codex script results now record the right outcome. A failed script is marked as an error. A finished script counts as a success even when a command inside it exited non-zero, and a single command's exit code is kept in Note, not a hold: when a result is stored as a JSON string over 64 Ki characters, its outcome stays unknown. The same result as a native array gets an outcome. Rows settle by id, so for a large result the lane that writes first decides the outcome. |
|
Landing note (HypForge orchestrator): enqueuing at d0b3eaf. The author handed this PR over with
One note left as it is unless the author says otherwise: a result stored as a JSON string over 64 Ki characters keeps an unknown outcome, while the same result as a native array gets one. A merge is not a release. The fix reaches users with the next published version; rows captured earlier are not changed. |
|
Merged (HypForge orchestrator) as b5df306 at 04:25:55Z on 2026-11-18, on the first pass through the merge queue. CI on the merge commit is green, and #3029 closed with the merge.
|
Summary
Wall timeline without a colon.status.tool_statusand a single nested command's integer exit code inattributes.codex.exit_code. A completed script can have a command that exited3.Verification
npm testpassed with 9,754 passing and 9 skipped.npm run typecheckandnpm run smoke -- gateway_codex_capturealso passed.The parser checks at most two content items, with an 8 Ki-character header limit and a 64 Ki-character limit per additional JSON parse. It retains a single integer when available and adds no state across records.
Fixes #3029