Skip to content

Add standalone GitHub connection flow - #3026

Merged
HypForge merged 1 commit into
masterfrom
codex/standalone-github-connect
Nov 18, 2026
Merged

HypForge merged 1 commit into
masterfrom
codex/standalone-github-connect

Conversation

@philcunliffe

Copy link
Copy Markdown
Contributor

Summary

Add hyp github connect for users who want to enable GitHub collection and sign in without rerunning hyp setup.

  • Enable GitHub and its context graph dependency while preserving repository settings and centrally managed entries.
  • Reuse GitHub device-code sign-in, including --no-browser, and restart a running service daemon after authorization.
  • Lead the integration guide with the standalone command. The default capture scope remains repositories seen in recorded AI sessions.

Config changes run once per connection attempt. The capture loop gains no work, and the diff review found no CPU or memory concerns.

Verification

The full npm test suite passed before rebasing. On the final branch, type checking, the targeted CLI and onboarding tests, and the GitHub and Linear integration smokes passed. The GitHub smoke uses a simulated OAuth provider and starts without an existing configuration.

@philcunliffe philcunliffe added the neutral:adopt Foreign PR adopted into neutral's reconcile scope label Nov 18, 2026
@HypForge HypForge added the neutral:adopted Adoption completion record: merged while carrying neutral:adopt (LLP 0031) label Nov 18, 2026
@HypForge

Copy link
Copy Markdown
Contributor

Final review (HypForge steward) at head e0a027f.

Rating: LOW. No defect found. This PR adds hyp github connect, which turns on GitHub collection and signs in in one step.

What was checked:

  • hyp linear connect is unchanged. The four central-managed refusals print the same text and write nothing on master and on this head. The Linear and GitHub capture and withholding smokes pass on both. The shared write path has the same semantics: one backup, mode kept, symlink followed, mtime guard, fsync.

  • The GitHub flow. I ran it in a temp HOME with fetch mocked and a mock systemctl. Cases covered:

    • access denied, an expired code and Ctrl-C;
    • success with and without a service unit, and a failed restart;
    • central enabled:true, central both and central context-graph enabled:false;
    • an unreadable config and an unknown flag.

    Every case gave the expected exit code, config write and message. No new config key; only an explicit enabled: false is flipped. The token never appears in output, and credentials.json is 0600.

  • Onboarding. The three callers of enableGithubCollection behave as before. One change: an entry with no enabled key no longer gains "enabled": true, which means the same thing.

  • Collection scope is unchanged: default inventory session_repos; poll and withholding code untouched.

  • Docs and LLPs. CLI_REFERENCE, integrations/github.md and INTEGRATIONS.md match the code. LLP 0615 matches the code, and its number appears on no other branch.

  • Overlap with Shorten the CLI: top-level fix, purge and skills, a recommendation group, direct query graph and vector #3024. Six files overlap. There are two list-edit conflicts (core_commands.js and cli-consistency-gate.test.js), and Shorten the CLI: top-level fix, purge and skills, a recommendation group, direct query graph and vector #3024 takes them when it rebases after this lands.

  • CPU and memory: no concern. One config read and one guarded write per run.

  • Privacy: LOW (hypforge LLP 0015 scale). It is a new way into the existing collector, enabled only by an explicit command, with the repo scope disclosed before the code. Security: no new input path; sign-in and token storage are the existing code.

Gates:

Not run (blocked): a real GitHub device sign-in, which needs a GitHub account and a browser to approve the code. The macOS LaunchAgent restart was also not run. It uses the same restart seam as hyp linear connect.

Not blocking, the author's call: after a failed connect, three hints disagree. Login says "run hyp github login again", connect says "Re-run hyp github connect", and status says "run hyp github login". Following login signs in but does not restart the daemon. Leaving it is fine (a restart picks it up); a small follow-up could have connect suppress login's own retry hint.

@HypForge

Copy link
Copy Markdown
Contributor

Landing note (HypForge orchestrator): enqueuing at e0a027f. The author handed this PR over with neutral:adopt at 00:06Z on 2026-11-18. It lands on a clean LOW review with green checks, so there is no merge ask.

  • Review: LOW, no defect, at this exact head (final comment above, 6966769928). Privacy LOW. Security: no new input path. CPU and memory: no concern.
  • Server-suite gate: pass. The new telemetry name github connect needed hypaware-server Fix #1685: hypaware-privacy Step 1 ambiguity guard misses a reroute placed past its one-paragraph routing slice #1730, which is merged and live. Server master 5e8b8a4b passes 749 of 749 against this head and against this head merged with client master.
  • HypForge pushed nothing to this branch.
  • Guard: open, not a draft, CLEAN, all checks green including test-windows, master CI green, no release PR open, merge queue empty. The branch is 2 behind master; the merge queue runs CI on the merged tree.
  • Not run: a real GitHub device sign-in, and the macOS LaunchAgent restart. No seat has a GitHub account with a browser, or a Mac.

One point left as it is unless the author says otherwise: after a failed connect, three hints disagree (login, connect and status each name a different next command).

A merge is not a release. The command reaches users with the next published version. #3024 overlaps this PR in six files and is rebased after this lands.

@HypForge
HypForge added this pull request to the merge queue Nov 18, 2026
Merged via the queue into master with commit 6282dc0 Nov 18, 2026
10 checks passed
@HypForge
HypForge deleted the codex/standalone-github-connect branch November 18, 2026 02:09
@HypForge

Copy link
Copy Markdown
Contributor

Merged (HypForge orchestrator) as 6282dc0 at 02:09:36Z on 2026-11-18, on the first pass through the merge queue. CI on the merge commit is green.

  • This is on master only. hyp github connect reaches users with the next client release; the published 1.53.0 does not have it.
  • The server already admits the new telemetry command (hypaware-server Fix #1685: hypaware-privacy Step 1 ambiguity guard misses a reroute placed past its one-paragraph routing slice #1730, live since 01:55Z).
  • Docs: the changed pages are on master. The site publishes docs from master at its next deploy, so site merges are held until the release that carries this command and hyp linear connect.
  • Not run: a real GitHub device sign-in and the macOS LaunchAgent restart.
  • The point about the three hints after a failed connect stands as the author's call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

neutral:adopt Foreign PR adopted into neutral's reconcile scope neutral:adopted Adoption completion record: merged while carrying neutral:adopt (LLP 0031)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants