Skip to content

ui-default: fix domain template name#1180

Merged
undefined-moe merged 1 commit into
masterfrom
template-name
Jun 13, 2026
Merged

ui-default: fix domain template name#1180
undefined-moe merged 1 commit into
masterfrom
template-name

Conversation

@pandadtdyy

@pandadtdyy pandadtdyy commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Fixed template selection to correctly identify domains, ensuring templates are properly rendered for the intended domain context.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 87aa8ef9-7f64-4dc0-b88f-e98925775673

📥 Commits

Reviewing files that changed from the base of the PR and between 44df5f0 and 323fc59.

📒 Files selected for processing (1)
  • packages/ui-default/backendlib/template.ts

Walkthrough

This change updates the TemplateService in packages/ui-default/backendlib/template.ts to derive the domain identifier from h.domain._id instead of args.domainId when constructing the template name for HTML rendering. The modification changes the source of the domain identifier used to select or namespace templates per domain when serving ui-default templates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: fixing how domain template names are constructed in the ui-default package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch template-name

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/ui-default/backendlib/template.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@undefined-moe undefined-moe merged commit fbf2737 into master Jun 13, 2026
8 checks passed
@undefined-moe undefined-moe deleted the template-name branch June 13, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants