Skip to content

[node-maintenance-repair/5] Render bounded repair choices and folded evidence - #48

Open
omry wants to merge 1 commit into
pr47from
pr48
Open

omry wants to merge 1 commit into
pr47from
pr48

Conversation

@omry

@omry omry commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Add revision-bound repair choices to the shared report renderer. Derive up to twenty exact pnpm same-minor patch attempts from published versions that satisfy all applicable advisories and checked parent constraints. Keep uncertain or incompatible pins unavailable for automatic attempts.

Show distinct needs-review and blocked states, folded evidence directly under the affected row, and instructions to submit /repair selected in the PR conversation. Match the App consent grammar and fingerprints while preserving platform and package reports. Consumer publication binding and real dependency repair remain later delivery slices.

Validation: 1,346 Python tests, 37 shared JavaScript fixtures, Ruff, Pyrefly, actual GitHub GFM rendering, and a clean independent full review.


…evidence

Add revision-bound repair choices to the shared report renderer. Derive up to twenty exact pnpm same-minor patch attempts from published versions that satisfy all applicable advisories and checked parent constraints. Keep uncertain or incompatible pins unavailable for automatic attempts.

Show distinct needs-review and blocked states, folded evidence directly under the affected row, and instructions to submit /repair selected in the PR conversation. Match the App consent grammar and fingerprints while preserving platform and package reports. Consumer publication binding and real dependency repair remain later delivery slices.

Validation: 1,346 Python tests, 37 shared JavaScript fixtures, Ruff, Pyrefly, actual GitHub GFM rendering, and a clean independent full review.
@omry
omry changed the base branch from main to pr47 October 24, 2026 21:57
@omry
omry added this pull request to stack #44 October 24, 2026 21:58
@omry

omry commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:397b4350b70c90b7624247103342698361bdcd8e36179444a923aed2969c6a46",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:397b4350b70c90b7624247103342698361bdcd8e36179444a923aed2969c6a46",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 120998999686
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 120998999426
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 120998999603
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 120998999622
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 120998999752
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 120998999623
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 120998999738
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 120998999633
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:ee2c537a5acf44f52dd21d65612be6099b89d47bab3fbf406a337ae955b7b59a",
      "review_request": {
        "body_digest": "sha256:88057150bf916c8ec89597e6b138e8995c8936afadf5a55d4f56fccec2fc6c49",
        "id": 6390146103
      },
      "review_result": {
        "body_digest": "sha256:acfcaa87de4ae79d35c3174ec152d2b1f067e58691138761db41809492fbca58",
        "id": 6390155531
      }
    },
    "evidence_fingerprint": "sha256:d0a8e854d32c470c1b69c9a53e9d98d87acc065e753cf7af8efd46dda327be5e",
    "head_sha": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
    "operation_identity": "sha256:ee2c537a5acf44f52dd21d65612be6099b89d47bab3fbf406a337ae955b7b59a",
    "review_request_id": 6390146103,
    "review_result_id": 6390155531,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:397b4350b70c90b7624247103342698361bdcd8e36179444a923aed2969c6a46",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "repair-app",
      "run_id": 120998999686
    },
    {
      "conclusion": "SUCCESS",
      "name": "test",
      "run_id": 120998999426
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, npm, 11.9.0)",
      "run_id": 120998999603
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.20.0)",
      "run_id": 120998999622
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.21.0)",
      "run_id": 120998999752
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, npm, 11.9.0)",
      "run_id": 120998999623
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.20.0)",
      "run_id": 120998999738
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.21.0)",
      "run_id": 120998999633
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 120998999686,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40136490595/job/120998999686"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 120998999426,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40136490595/job/120998999426"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 120998999603,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40136490595/job/120998999603"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 120998999622,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40136490595/job/120998999622"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 120998999752,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40136490595/job/120998999752"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 120998999623,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40136490595/job/120998999623"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 120998999738,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40136490595/job/120998999738"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 120998999633,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40136490595/job/120998999633"
        }
      ],
      "head_sha": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
      "id": "sha256:d99d400efd4e412a15ffbbb29fa22bea270116dbd507695e7fb66570fab916d7",
      "required_checks": [
        "repair-app",
        "test",
        "toolchain (22, npm, 11.9.0)",
        "toolchain (22, pnpm, 11.20.0)",
        "toolchain (22, pnpm, 11.21.0)",
        "toolchain (24, npm, 11.9.0)",
        "toolchain (24, pnpm, 11.20.0)",
        "toolchain (24, pnpm, 11.21.0)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr47",
    "base_sha": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
    "body_digest": "sha256:90073b9f2b49409d324849b5eb0fdc7bb4458859dd9fc3238d3267bcb8578f07",
    "body_identity_version": 2,
    "diff_digest": "sha256:d685d870d2099cbf43df9a53530e5142bfc7cd78ad28dbe4230931a74f72750f",
    "head_ref": "pr48",
    "head_sha": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
    "pr": 48,
    "repository": "hydra-ecosystem/github-actions",
    "scope_authority": [],
    "title_digest": "sha256:dae5b78164abd618ccd07a47e4b8690c0f2c8bbd5d2d2a98bccd4c7bf03fc0c2"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-10-24T21:57:45Z",
      "base_ref": "pr47",
      "base_sha": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "body_digest": "sha256:88057150bf916c8ec89597e6b138e8995c8936afadf5a55d4f56fccec2fc6c49",
      "created_at": "2026-10-24T22:09:05Z",
      "head_sha": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
      "id": 6390146103,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr47",
      "base_sha": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "body_digest": "sha256:acfcaa87de4ae79d35c3174ec152d2b1f067e58691138761db41809492fbca58",
      "commit_id": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
      "id": 6390155531,
      "inline_message_ids": [],
      "request_comment_id": 6390146103,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-24T22:10:04Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:397b4350b70c90b7624247103342698361bdcd8e36179444a923aed2969c6a46",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:d685d870d2099cbf43df9a53530e5142bfc7cd78ad28dbe4230931a74f72750f",
      "finding_ids": [],
      "invariants": [],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
      "review_observation_id": null,
      "review_request_id": 6390146103,
      "review_result_id": 6390155531,
      "reviewed_head": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 24, 2026 22:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T22:10:05.670029Z f37ec4f Manual request
🔒 Security Review ✅ Completed 2026-10-24T22:09:06.270821Z f37ec4f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Exact head: f37ec4f

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: f37ec4f2a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant