Repository navigation
fix(LinkPreview): always clean up the document pointerup listener - #2194
Open
Blackman99 wants to merge 1 commit into
Open
Blackman99 wants to merge 1 commit into
Blackman99 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 973196e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2153
The open watcher in
LinkPreviewRootStateadds apointeruplistener on the document, but whencontentNodeis still null it returns early, before the cleanup is returned. The listener then never gets removed and keeps firing after the preview closes or unmounts, which is where the repeatedderived_inertwarnings come from.This guards the
contentNode/tabindex block instead of returning early, so the cleanup is always returned.pointeruplistener is removed after the preview unmounts (fails on main, passes with this change)bits-uipatch changesetDoesn't touch the separate
afterSleeptimer issue (#2103) or #2146.