Repository navigation
fix(Tabs, Accordion): ignore nested root triggers in keyboard navigation - #2190
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 24be777 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
…ems in keyboard navigation
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2189
RovingFocusGroupcollects candidates withquerySelectorAll, which also matches the triggers of a nestedTabs.RootorAccordion.Root. SoEndand arrow-key wrapping on the outer list jump into the nested one, or do nothing when it sits in a hidden panel.Changes
rootAttrtoRovingFocusGroup. When set, only candidates whose closest[rootAttr]ancestor is the group's own root are kept.TabsandAccordionpass their root attribute. Other components are unchanged.Tests
Added a nested-root test for Tabs and for Accordion. Both fail on
mainand pass with this change, and the full browser suite passes in Chromium.ToggleGroup, RadioGroup, Toolbar and the other roving-focus components could opt in the same way in a follow-up.