Repository navigation
Conversation
…_packages.py needs tests/test_wheel_packages.py runs `setup.py build_py` on a copy of the sources. The parity job's `uv run --no-project --python 3.12 --with ...` environment has no setuptools: Python 3.12 does not ship it, and only the Ubuntu runners' system Python happens to carry one. On windows-x64 and macos-arm64 both tests failed with `ModuleNotFoundError: No module named 'setuptools'` (runs 40102813583 and 40109358404; every other file passed, 969 tests on Windows), which turned the required macos-arm64 gate red as well. Add `--with setuptools` to the parity run, as pyproject.toml already does for the JVM test extra. The second test also starts a child with an environment of only PATH; pass SYSTEMROOT through on Windows, where a child without it cannot import socket. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Add windows-x64 to REQUIRED_PLATFORMS, so a native-v* tag publishes only when the Windows parity run also passed, and update the release notes. Windows already built its wheel and passed 969 tests on the installed wheel; its only red were the two test_wheel_packages.py tests fixed in the previous commit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tae898
added a commit
to ArcadeData/arcadedb-python
that referenced
this pull request
Oct 25, 2026
…to the Windows child test_wheel_packages builds with setup.py build_py; the uv parity env had no setuptools, so the test failed on windows-x64 and macos-arm64 and passed on Linux only because the runner's Python ships it (humemai/arcadedb-embedded-python#539). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tae898
marked this pull request as ready for review
October 25, 2026 12:24
Author
|
Closing as superseded. The native build now ships from ArcadeData/arcadedb-python, and the same fix (setuptools in the parity environment, SYSTEMROOT for the Windows child) is ArcadeData/arcadedb-python@a561129 in ArcadeData/arcadedb-python#66, where all four platforms are already required. Thanks for the diagnosis: the missing setuptools also broke macos-arm64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
The Windows parity job of
native-preview.ymlwas red in the last two runs that reached it (40102813583 and 40109358404; run 40067414506 before them was green). Both runs show the same single cause. The job ran 969 tests on the installed wheel and only the two tests oftests/test_wheel_packages.pyfailed, withModuleNotFoundError: No module named 'setuptools'fromsetup.py.That file builds the JVM sources with
setup.py build_py. The parity job'suv run --no-project --python 3.12 --with ...environment has no setuptools, because Python 3.12 does not ship it. Only the Ubuntu runners' system Python happens to carry one, so Linux passed. macOS arm64, which is a required platform, failed on the same two tests in run 40109358404, so this also unblocks the required gate.Counted causes on Windows: 1 cause (test harness, missing
setuptoolsin the parity environment), 2 failing tests. Path handling, file locking, line endings, encoding, temp-dir cleanup, ctypes loading and the DLL search path produced no failure, and there is no native defect. Nothing is skipped to get there.Fix
native-preview.yml: add--with setuptoolsto the parity run, aspyproject.tomlalready does for the JVM test extra.test_wheel_packages.py: the second test starts its child with an environment of onlyPATH. PassSYSTEMROOTthrough where it exists, because a Windows child without it cannot importsocket. This is a precaution for the first Windows run of that test, not something the logs showed.REQUIRED_PLATFORMSgetswindows-x64(last commit), with the release notes updated. Drop that commit if the run below is not green on Windows.Reproduced locally: with a managed Python 3.12 and no setuptools the file fails the same two tests; with
--with setuptoolsboth pass.CI
One dispatched run of
native-preview.ymlon this branch: https://github.com/humemai/arcadedb-embedded-python/actions/runs/40188494129 (the workflow has no per-job input, so this builds all four platforms).🤖 Generated with Claude Code