Skip to content

Make generated blocks work with WordPress 7.1 pattern overrides - #16

Draft
noeltock wants to merge 3 commits into
mainfrom
foundry/6-make-generated-blocks-work-with-wordpress-7-1-pattern-overri
Draft

Make generated blocks work with WordPress 7.1 pattern overrides#16
noeltock wants to merge 3 commits into
mainfrom
foundry/6-make-generated-blocks-work-with-wordpress-7-1-pattern-overri

Conversation

@noeltock

@noeltock noeltock commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

“Reusable” should not force editors to choose between one globally synced design and instance-specific content. Metadata alone cannot prove pattern overrides work, and structural InnerBlocks are not bindable. Closes #6.

Solution

The structural proof is now adequately scoped to the generated wrapper and its direct layout child. The revision remains blocked because neither the required passing receipt nor the reviewed visual baseline is committed.

⚠️ Verification files modified

  • package.json

  • Assumed in scope: package.json — the implementation requires this verification change despite the path not being named.

Testing & verification

  • Coverage gap — no test file changed; no targeted test was added for this revision: The structural proof is now adequately scoped to the generated wrapper and its direct layout child. The revision remains blocked because neither the required passing receipt nor the reviewed visual baseline is committed.
  • Local runnpm run typecheck → pass.
  • Local runnpm run test → pass.
  • Local runnpm run build → pass.
  • Not run — no live/manual verification; this Foundry run has no browser.

Risk / rollout

Small, targeted change — see the diff for the affected paths.

Must-fix blockers from review

  • missing-wordpress-receipt · The repair invokes the real WordPress test, but it still writes its receipt only to a temporary directory and commits no passing WordPress 7.1 receipt containing the canonical wp_block content and both instances’ core/block.content values.
  • tautological-visual-baseline · The self-comparison was removed, but the referenced reviewed PNG golden is absent from the change and repository. The fixture test therefore fails its existence check, and no deterministic reviewed visual baseline is available for the runtime comparison.

Built by 🪺 Rookery · flight #52 · 33m48s · 2 passes · gpt-5.6-terra·xhigh

@noeltock

noeltock commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Independent adjudication of Warden's blocker (Codex gpt-5.6-sol, high)

Requested by Noel: the blocker judged against the diff rather than waiting. Confirmed — the guidance below is the revision brief.

VERDICT: CONFIRMED

The committed real-WordPress test is skipped unless four external artifacts are supplied, including the plugin ZIP and visual golden. More importantly, patternOverrides.canonicalContent contains only hand-authored core/group, core/heading, core/image, and core/button blocks; block-runner/pattern-overrides-fixture is tested separately and never participates in the synced pattern. The pattern gate can therefore pass while the generated block’s override integration is broken, so the required end-to-end receipt is not reproducible or proven by this diff.

Minimal fix: commit or deterministically build the generated fixture plugin and golden during the test workflow, construct the synced pattern from that fixture’s actual generated output—including the generated block—and run the full unskipped WordPress 7.1 lifecycle against it. Commit a passing receipt containing the canonical wp_block content and both instances’ core/block.content values.

OVERALL: REVISE — The implementation adds substantial override plumbing and a detailed proof runner, but its decisive integration proof tests an unrelated Core-block pattern and depends on unavailable external files. The change should not be promoted until the generated block itself is exercised through the complete synced-pattern lifecycle.

@noeltock

noeltock commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Round-4 adjudication (Codex gpt-5.6-sol, high, severity-aware)

missing-wordpress-receipt

VERDICT: DEFER

The Docker-backed test generates an immutable receipt, pins WordPress 7.1, and asserts that it contains canonical wp_block markup plus two distinct persisted core/block.content maps. Keeping that receipt only in mkdtemp() limits auditability, but does not undermine runtime correctness or the tested acceptance criteria.

Persist WordPress 7.1 proof receipts as CI artifacts

Publish the receipt and its content-addressed evidence directory from the WordPress acceptance job. Document retention and make the artifact discoverable from the relevant build so reviewers can inspect the exact lifecycle evidence without committing environment-specific receipts.

tautological-visual-baseline

VERDICT: MUST-FIX

The fixture explicitly requires proof/wordpress-7.1-pattern-overrides.expected.png, checks its exact SHA-256, and the full profile requires visual_regression to pass. If that file is absent from the repository, a clean checkout cannot pass even if a developer’s working tree contains an untracked copy; this contradicts both npm run verify and the README’s checked-in-golden claim.

Minimal fix: add the reviewed PNG at the referenced path, ensure it is tracked and matches the asserted digest, then rerun the fixture test and full WordPress proof from a clean checkout.

OVERALL: REVISE

The missing retained receipt can follow as CI-proof infrastructure because the lifecycle is already exercised and asserted. The absent visual golden is merge-blocking: it makes the stated verification path dependent on an uncommitted local file and prevents reproducible validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make generated blocks work with WordPress 7.1 pattern overrides

1 participant