Make generated blocks work with WordPress 7.1 pattern overrides - #16
Make generated blocks work with WordPress 7.1 pattern overrides#16noeltock wants to merge 3 commits into
Conversation
Independent adjudication of Warden's blocker (Codex gpt-5.6-sol, high)Requested by Noel: the blocker judged against the diff rather than waiting. Confirmed — the guidance below is the revision brief. VERDICT: CONFIRMED The committed real-WordPress test is skipped unless four external artifacts are supplied, including the plugin ZIP and visual golden. More importantly, Minimal fix: commit or deterministically build the generated fixture plugin and golden during the test workflow, construct the synced pattern from that fixture’s actual generated output—including the generated block—and run the full unskipped WordPress 7.1 lifecycle against it. Commit a passing receipt containing the canonical OVERALL: REVISE — The implementation adds substantial override plumbing and a detailed proof runner, but its decisive integration proof tests an unrelated Core-block pattern and depends on unavailable external files. The change should not be promoted until the generated block itself is exercised through the complete synced-pattern lifecycle. |
Round-4 adjudication (Codex gpt-5.6-sol, high, severity-aware)missing-wordpress-receiptVERDICT: DEFER The Docker-backed test generates an immutable receipt, pins WordPress 7.1, and asserts that it contains canonical Persist WordPress 7.1 proof receipts as CI artifacts Publish the receipt and its content-addressed evidence directory from the WordPress acceptance job. Document retention and make the artifact discoverable from the relevant build so reviewers can inspect the exact lifecycle evidence without committing environment-specific receipts. tautological-visual-baselineVERDICT: MUST-FIX The fixture explicitly requires Minimal fix: add the reviewed PNG at the referenced path, ensure it is tracked and matches the asserted digest, then rerun the fixture test and full WordPress proof from a clean checkout. OVERALL: REVISEThe missing retained receipt can follow as CI-proof infrastructure because the lifecycle is already exercised and asserted. The absent visual golden is merge-blocking: it makes the stated verification path dependent on an uncommitted local file and prevents reproducible validation. |
Problem
“Reusable” should not force editors to choose between one globally synced design and instance-specific content. Metadata alone cannot prove pattern overrides work, and structural InnerBlocks are not bindable. Closes #6.
Solution
The structural proof is now adequately scoped to the generated wrapper and its direct layout child. The revision remains blocked because neither the required passing receipt nor the reviewed visual baseline is committed.
package.jsonAssumed in scope: package.json — the implementation requires this verification change despite the path not being named.
Testing & verification
npm run typecheck→ pass.npm run test→ pass.npm run build→ pass.Risk / rollout
Small, targeted change — see the diff for the affected paths.
Must-fix blockers from review
Built by 🪺 Rookery · flight #52 · 33m48s · 2 passes · gpt-5.6-terra·xhigh