Support existing wp-scripts plugins and standalone plugin output - #14
Support existing wp-scripts plugins and standalone plugin output#14noeltock wants to merge 2 commits into
Conversation
Independent adjudication of Warden's blockers (Codex gpt-5.6-sol, high)Requested by Noel: each blocker judged against the diff rather than waiting. Confirmed items below are the revision brief. VERDICT: CONFIRMED — OVERALL: REVISE. The detector can approve a plugin whose build command bypasses the discovery method that generated blocks depend on. A small validation rule and regression test are required before this is safe to merge. |
Exact changes
Testing
Trade-offs
Commit: |
Problem
A folder of block files is not “build-ready” unless it matches the destination plugin's source root, build root, build dependency, entry discovery, and PHP registration strategy. Guessing those conventions risks a block that compiles nowhere or an unsafe edit to an existing plugin. Closes #7.
Solution
Most original blockers were repaired, but host recognition still accepts a custom build shape that is incompatible with the planned integration. The pull request is ready for review.
Testing & verification
npm run typecheck→ pass.npm run test→ pass.npm run build→ pass.Risk / rollout
Small, targeted change — see the diff for the affected paths.
Must-fix blockers from review
wp-scripts build custom.js. Those disable metadata-based entry discovery, so the host can be misclassified and generated files placed where its build will not process them.Built by Foundry (writer: Codex; independent review: Warden — block, 1 blockers).