feat: rework python bindings - #2391
Open
SBrandeis wants to merge 26 commits into
Open
Conversation
SBrandeis
force-pushed
the
feat/rework-python-bindings
branch
from
September 3, 2026 11:13
6f591e2 to
20cd29c
Compare
Member
|
I could confirm that pickling, multiprocessing and pickle-dump-hash determinism are all good wrt I can try e2e with |
ArthurZucker
approved these changes
Sep 4, 2026
| pipeline: Pipeline, | ||
| // Needs a mutex so a concurrent thread can access the value while | ||
| // encode is running. | ||
| padding: Mutex<Option<PaddingParams>>, |
Collaborator
There was a problem hiding this comment.
fine, its also fine if its just copied across threads tbf
| tokenizer.save("./path/to/directory/my-bpe.tokenizer.json") | ||
| from tokenizers import Padding, Tokenizer | ||
|
|
||
| tokenizer = Tokenizer.from_file("tokenizer.json") |
Collaborator
There was a problem hiding this comment.
needs from pretrained + a big disclaimer that this is v1 only!
Comment on lines
+64
to
+65
| with multiprocessing.get_context("spawn").Pool(4) as pool: | ||
| encoded = pool.starmap(encode, [(tokenizer, chunk) for chunk in chunks]) |
Collaborator
There was a problem hiding this comment.
we need to check, potentially disabling the parallelism automatically when in subprocess -> user wants to handle it himself
Contributor
Author
|
Hey @ArthurZucker I addressed some of your concerns:
PTAL at those changes 🤗 |
…at/rework-python-bindings
…at/rework-python-bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Rework of the Python bindings to make them slimmer (minimalistic API)
Some caveats: