Fix ERC1967Upgrade.huff offset bug and incorrect delegatecall params#147
Open
kadenzipfel wants to merge 3 commits into
Open
Fix ERC1967Upgrade.huff offset bug and incorrect delegatecall params#147kadenzipfel wants to merge 3 commits into
kadenzipfel wants to merge 3 commits into
Conversation
kadenzipfel
force-pushed
the
fix/ERC1967-offset-bug
branch
from
de52da7 to
cb72c01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the incorrect byte offset to retrieve passed calldata, starting from the function selector when we should start immediately after it
Additionally, testing this fix uncovered another bug: the delegatecall parameters are all mixed up due to incorrect stack management
Neither of the affected macros appear to have ever been deployed to production