Fix SSL certificate verification on macOS - #1941
Open
vinayK34 wants to merge 1 commit into
Open
Conversation
This fixes httpie#1632 where HTTPie fails to verify SSL certificates on macOS even though requests works fine in the same environment. The root cause is that urllib3.util.ssl_.create_urllib3_context() creates SSL contexts without CA certificates, which causes certificate verification to fail. This fix ensures that when verify=True, we load the default certificates if needed. Fixes the issue by: 1. Ensuring certificates are loaded when verify=True 2. Adding a safety check for contexts that might have 0 certificates 3. Handling potential exceptions gracefully 4. Preserving backward compatibility
vinayK34
marked this pull request as ready for review
August 26, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1632 where HTTPie fails
to verify SSL certificates on macOS even though requests works fine in
the same environment.
The root cause is that
urllib3.util.ssl_.create_urllib3_context()createsSSL contexts without CA certificates, which causes certificate verification
to fail. This fix ensures that when
verify=True, we load the defaultcertificates if needed.
Fixes the issue by:
verify=True