fix: prevent notifications dropdown from closing when scrolling panel (fixes #314)

[trtajim]

Summary by CodeRabbit

• Bug Fixes
  • Notification dropdowns now remain open while scrolling through the notification list.

[coderabbitai]

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 97cd43cc-feb3-4bb8-a5e5-b269c3ad5327

📥 Commits

Reviewing files that changed from the base of the PR and between 6fb4cb8 and 53b4450.

📒 Files selected for processing (3)

• GEMINI.md
• app/Http/Controllers/Admin/EmailController.php
• resources/js/pages/admin/EmailSend.vue

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: ed7b5f78-bfe2-4a54-9f27-fb1af1e68a30

📥 Commits

Reviewing files that changed from the base of the PR and between a0b8089 and 6fb4cb8.

📒 Files selected for processing (1)

• resources/js/components/NotificationDropdown.vue

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The notification dropdown scroll handler now ignores events from the notification panel, preventing the dropdown from closing while users scroll notification items.

Changes

Notification scroll handling

Layer / File(s)	Summary
Filter notification panel scroll events resources/js/components/NotificationDropdown.vue	handleScroll now ignores scroll events from both the dropdown trigger and notification panel.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 6fb4c

Scrolling within the notification panel will keep the dropdown open as intended, with no identified merge-blocking risk.

Suggested reviewers: thetahsinshahriar

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: keeping the notifications dropdown open when the panel is scrolled. It also references the related issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/notification-dialog-scroll-314

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}