Skip to content

[example]: fix Pytorch_DDP/Pytorch_ZeRO plans crashing in gpt gemini demo #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiRunGuo wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −3
Open

[example]: fix Pytorch_DDP/Pytorch_ZeRO plans crashing in gpt gemini demo #6445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a2637
[example] fix Pytorch_DDP/Pytorch_ZeRO plans in gpt gemini demo
LiRunGuo Sep 21, 2026
e7a3aa0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/language/gpt/gemini/train_gpt_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ def main():

logger.info(get_mem_info(prefix="After init optim, "), ranks=[0])
elif args.distplan.startswith("Pytorch"):
assert args.tp_degree == 1, "The degree of TP should be 1 for DDP examples."
model = model_builder(args.model_type)(checkpoint=True).cuda()
plugin = TorchDDPPlugin()
if args.distplan.endswith("DDP"):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_checkpoint_io/test_gemini_checkpoint_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

ASYNC_MODES = [False, True] if HAS_TENSORNVME else [False]
try:
import apex.amp
pass

APEX_AVAILABLE = True
except ImportError:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_zero/test_gemini/test_optim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from tests.kit.model_zoo import model_zoo, run_fwd_bwd

try:
import apex.amp
pass

APEX_AMP_AVAILABLE = True
except ImportError:
Expand Down