[fp8]: Read detected local world size environment variable - #6438
Open
tandede wants to merge 1 commit into
Open
Conversation
tandede
marked this pull request as ready for review
August 20, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise descriptionpip install pre-commit && pre-commit install🚨 Issue number
Fixed #6437
📝 What does this PR do?
process_group_is_intranode()previously detected the first available local-world-size environment variable but always readLOCAL_WORLD_SIZE. Jobs launched with OpenMPI or Slurm therefore raisedKeyErrorbefore FP8 collectives could select the intranode path.This change reads the detected variable and stops at the first match, preserving the existing priority order: torchrun, OpenMPI, then Slurm.
Regression tests cover:
Validation:
pytest -q --confcutdir=tests/test_fp8 tests/test_fp8/test_fp8_utils.py— 7 passedpre-commit run --files colossalai/quantization/fp8.py tests/test_fp8/test_fp8_utils.py— all hooks passedThe repository-level test fixture invokes GPU accelerator cache hooks during collection, so the full GPU suite is left to CI; the new regression itself is CPU-safe.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?