Skip to content

feat: allow setting of arbitrary env vars in application#1

Open
lukeplausin wants to merge 1 commit into
hops-ops:mainfrom
lukeplausin:feat/extra-env-vars
Open

feat: allow setting of arbitrary env vars in application#1
lukeplausin wants to merge 1 commit into
hops-ops:mainfrom
lukeplausin:feat/extra-env-vars

Conversation

@lukeplausin

@lukeplausin lukeplausin commented Jun 16, 2026

Copy link
Copy Markdown

This change allows a chart operator to set any arbitrary env keys / values to the individual components (or all components) when deploying. Added as I wanted to use SMTP which has been developed upstream but is not present in this chart version.

Summary by CodeRabbit

  • New Features
    • Added support for injecting custom Kubernetes environment variables into service deployments.
    • Configure global environment variables applied across all microservices.
    • Set per-service environment variables for individual components (API, Dashboard, Worker).

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8aee5870-478a-47bb-ad2e-dae9d27b02bd

📥 Commits

Reviewing files that changed from the base of the PR and between 009a642 and 9082ef4.

📒 Files selected for processing (5)
  • templates/_helpers.tpl
  • templates/api.yaml
  • templates/dashboard.yaml
  • templates/worker.yaml
  • values.yaml

📝 Walkthrough

Walkthrough

Adds extraEnv injection support to the OpenPanel Helm chart. A new openpanel.extraEnv helper merges a global extraEnv list with a per-service extraEnv list and renders the result as YAML. The helper is wired into the api, dashboard, and worker Deployment templates, and matching empty-list defaults are added to values.yaml.

Changes

extraEnv injection across all services

Layer / File(s) Summary
Helper definition and values schema
templates/_helpers.tpl, values.yaml
openpanel.extraEnv helper concatenates global and local lists and emits YAML only when non-empty; values.yaml adds global.extraEnv, api.extraEnv, dashboard.extraEnv, and worker.extraEnv as empty lists with inline docs.
Wiring into api, dashboard, and worker Deployments
templates/api.yaml, templates/dashboard.yaml, templates/worker.yaml
Each Deployment template gains a with include "openpanel.extraEnv" block that passes global and service-scoped extraEnv values, indenting the rendered entries into the container env: section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hop hop, the env vars flow,
Global or local, they merge just so.
A helper template, tidy and neat,
Injects each value — oh, what a treat!
All pods rejoice from worker to dash,
Extra env vars, delivered in a flash! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective—introducing the ability to set arbitrary environment variables across components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant