Repository navigation
No Merge button on pull requests you cannot merge; review token at push time - #7
Merged
Merged
Conversation
The pull request list is every open PR you opened, which includes PRs to projects you only contribute to. When one of those was green and mergeable, GitCleared offered Merge, and GitHub refused it: authoring a pull request does not give you write access to its repository. Read the repository's viewerPermission in the same query. READ or TRIAGE withholds the button with the reason "no write access"; a missing value is treated as unknown and changes nothing. The reason comes after checks and reviews, which are still worth seeing on a contribution, and before GitHub's own merge verdict, which it may not have worked out for a repository you cannot push to. Found while setting up the App Review demo: a token scoped to one demo repository can still read every public repository, so the reviewer would have seen the developer's open PR to a public project, possibly with a Merge button that fails. 0.4.2, build 5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…thout it The review notes describe the demo repository the reviewer signs in to, hollandcloud/gitcleared-demo, and what they will see there. The token line stays a placeholder in the repository. `asc.py review` substitutes GITCLEARED_REVIEW_TOKEN when it is set, and `asc.py submit` refuses while App Store Connect's copy of the notes still has the placeholder, since a reviewer who cannot sign in rejects the build. The owner's section has the token's exact settings and what to do before each submission: hold a fresh deployment, send the notes with the token, submit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits. Tracked on the board as LAB-11 (the fix) and LAB-9 (App Store).
1. Fix: Merge offered where GitHub refuses it
The pull request list is every open PR you opened, which includes PRs to projects you only contribute to. A green one got a Merge button that GitHub then refused, because opening a pull request doesn't give you write access to the repository.
The query now reads
viewerPermission. READ or TRIAGE withholds the button with the reason no write access; a missing value is treated as unknown and changes nothing.Found while preparing App Review: a token scoped to one demo repository can still read every public repository, so the reviewer would have seen the developer's open PR to a public project.
Version 0.4.2, build 5.
2. Review token, filled in at push time
The review notes now describe the demo repository the reviewer signs in to,
hollandcloud/gitcleared-demo.asc.py reviewtakes the token fromGITCLEARED_REVIEW_TOKEN, so it is never written into this repository.asc.py submitrefuses while App Store Connect's copy of the notes still has the placeholder.Verification
🤖 Generated with Claude Code