Repository navigation
fix(ui): the showcase reference and a feed that loads again once the stream connects - #20
Merged
Merged
Conversation
The reference was taken from a binary built before the shared controls joined the showcase: make e2e-visual builds only when there is no binary. e2e-visual-update now builds first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A request that came between the first load of the feed and the first connection of the stream was lost: there is no Last-Event-ID to replay it by. The transport now sends subscribers one resync when the stream first opens; reconnections still get the missed events from the server. The e2e test of page errors names its page apart in every run, so a retry or a repeat no longer finds the child of the run before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hightemp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make e2e-visualbuilds only whendist/wapp-debuggeris missing). Retaken from a fresh build;make e2e-visual-updatenow builds first.resyncwhen the stream first opens (unit test). The race did not show locally even without the fix. The test now names its page apart per run, so retries and repeats don't see earlier children.🤖 Generated with Claude Code