#692 commons lang plugin updates#695
Open
duttonw wants to merge 2 commits into
Open
Conversation
Updated documentation Introduce equals to allow deep recursive equals checks vs by reference (default): -Xcommons-lang:equalsTestTransients=TRUE|FALSE (default: FALSE) -Xcommons-lang:equalsTestRecursive=TRUE|FALSE (default: FALSE) Enable ability to disable parts of commons-lang to allow mixing and matching of plugins -Xcommons-lang:addToStringMethod=TRUE|FALSE (default: TRUE) -Xcommons-lang:addHashCodeMethod=TRUE|FALSE (default: TRUE) -Xcommons-lang:addEqualsMethod=TRUE|FALSE (default: TRUE) Streamlined -Xcommons-lang:ToStringStyle to look prefer Static Final variables that passes regex ^[A-Z0-9_]+$ else treat it as a Class, don't error if it can't find it, since it may not be visible to the generator (But do provide warnings of such cases). Also allow classes to be passed through even if NOT available to generator so plugin dependancies do not need to include additional jar's unless the developer wants to remove the warning. Requres: highsource#692 for unit testing to pass.
duttonw
force-pushed
the
692_commons-lang_plugin_updates
branch
from
b35bc65 to
9d42c33
Compare
Contributor
Author
|
Hi @mattrpav , Any suggestions if this needs improvements? or would you like it split into a few pr's? |
Collaborator
|
@duttonw : could you split into few PR's w/ specific change in each please ? Thanks |
Contributor
Author
|
Hi @laurentschoelens ,
|
Collaborator
|
Yes you can do that 😄 |
Contributor
Author
|
Hi @laurentschoelens , This is now split up. I've also included an all in one to help with merging since there will be merge clonflicts. #708 Disable Falgs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #692 for details, needs #691 for unit testing