feat: syntax-highlighted code blocks + fuzzy / @-file prompt autocomplete - #33
Merged
Merged
Conversation
…lete Borrows three ideas from earendil-works/pi-tui, adapted to our Ratatui stack: - Syntax highlighting: fenced code in assistant markdown is highlighted by language via syntect (pure-Rust fancy-regex, no C toolchain). Common LLM fence tags are normalised to a known syntax; unknown languages fall back to the previous flat-green rendering. Highlighting is stateful across a block and paid once per message version through the existing render cache. - @-file mention autocomplete: typing @ in the prompt opens a filesystem palette (relative to the focused session workdir), fuzzy-ranked against the partial path. Tab completes the top hit — directories keep a trailing slash to drill in, files get a trailing space. Handled as a runtime-conditional Tab binding, mirroring the existing esc-interrupts pattern. - Fuzzy slash-command matching: the / palette and Tab completion now rank by a fuzzy subsequence score (consecutive-run + word-boundary bonuses, gap penalties) instead of strict prefix; Tab commits the best match. New modules: fuzzy (scoring), mention (fs suggestions), render/highlight (syntect wrapper). All new code is clippy-pedantic clean, with unit tests across every new module. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
rsharath
approved these changes
Jul 26, 2026
rsharath
approved these changes
Jul 26, 2026
* feat: prompt history recall + undo/redo Second of two PRs borrowing prompt-editor ideas from pi-tui. - Prompt history: Up/Down recall previously submitted prompts, shell-style. Recall is gated to the editor's vertical edges (Up on the first row, Down on the last) so multi-line cursor movement is untouched; it's wired as a runtime-conditional binding in the reducer (like the existing esc-interrupt and @-mention Tab) since it depends on cursor row + history state. Stepping down past the newest entry restores the stashed live draft. History is de-duplicated against the newest entry and capped at PROMPT_HISTORY_MAX. - Undo/redo: Ctrl+Z / Ctrl+Y map to tui-textarea's built-in edit history via explicit keymap actions (discoverable + testable rather than relying on the library's default shortcuts). State gains prompt_history / history_index / history_draft plus record_history, set_prompt_text, history_prev, history_next. Full suite green; new unit tests cover history walk/restore/dedup/cap and the new keymap bindings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix: drop redundant clone in prompt history recall (oracle review) history_prev/next cloned prompt_history[i] into a String only to satisfy the borrow checker (can't hold &self.prompt_history[i] across a &mut self method). Replace the set_prompt_text method with a free `prompt_from_text(&str)` that doesn't borrow self, so callers pass &self.prompt_history[i] directly — no intermediate allocation. Behaviour unchanged; history tests still green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * refactor: back prompt history with VecDeque (oracle review) Front-trimming a Vec on each cap is an O(n) shift; a VecDeque makes dropping the oldest entry an O(1) pop_front, which is the semantically correct structure for a bounded ring buffer with front removals. Negligible at the 200-entry cap, but cleaner and future-proof. Behaviour and tests unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Borrows three ideas from
earendil-works/pi-tui— a mature TS TUI toolkit — adapted to our Ratatui stack. All three are additive, no architectural change.1. Syntax-highlighted code blocks
Fenced code in assistant markdown is now highlighted by language via
syntect(pure-Rustfancy-regexengine — no C toolchain / oniguruma, stays cross-compile friendly).rust,python,ts,bash,yml, …) are normalised to a syntaxsyntectknows.HighlightLinesper fence) and paid once per message version via the existing render cache — no per-frame cost.2.
@-file mention autocompleteTyping
@in the prompt opens a filesystem palette (relative to the focused session's workdir), fuzzy-ranked against the partial path.Tabcompletes the top hit: directories keep a trailing/so you can keep drilling; files get a trailing space.@src/re…), reveals dotfiles only when you type a leading dot.app.rs(mirrors the existingesc-interrupts pattern) so the static keymap and all its tests stay untouched.3. Fuzzy slash-command matching
The
/palette andTabcompletion now rank by a fuzzy subsequence score (consecutive-run + word-boundary bonuses, gap penalties) instead of strict prefix —/expsnfinds/export, andTabcommits the best match.New modules
fuzzy— subsequence scorer ported from pi-tui'sfuzzy.tsmention— filesystem suggestion rankingrender/highlight—syntectwrapper (lazyOnceLocksyntax/theme sets)Testing
cargo test --workspacegreen (314 tui tests + crate tests).cargo fmt --checkclean; all new code is clippy-pedantic clean.Notes
🤖 Generated with Claude Code