perf(sdk): reduce composition paint query work - #3123
Open
leorivastech wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Benchmarks and reduces the per-call DOM work in
compositionPaintsAtwhile preserving its ordering, full-bleed behavior, and lazy image-alpha sampling.On the committed deterministic 1,000-node fixture:
Fixes #3078.
Why
The paint query runs during pointer and playback updates. It previously resolved visibility and ancestor opacity eagerly for every contained candidate, reread styles during ink checks, walked ancestors again for depth, and reread root geometry for full-bleed handling.
Those repeated DOM reads dominate the query on large compositions and can interleave with animation writes.
How
area asc, depth descsort so a transparent minimum can fall through without eager alpha sampling.Test plan
Verified:
git diff --check, and all pre-commit hooksRegression coverage also verifies a moving root is observed across calls, a non-painting minimum falls through to the next candidate, alpha sampling stays at one read, and a 12,000-level ancestor chain does not overflow the stack.