feat: support ES module plugins - #5820
Open
stevenjoezhang wants to merge 1 commit into
Open
Conversation
How to testgit clone -b agent/support-esm-plugins https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
stevenjoezhang
marked this pull request as ready for review
August 12, 2026 18:45
Aetf
added a commit
to Aetf/Aetf.github.io
that referenced
this pull request
Aug 21, 2026
Set "type": "module" and move the real logic of all four hexo scripts to ESM modules under lib/, taking the hexo instance as an explicit parameter instead of the vm-injected global. Hexo still runs files under scripts/ as CJS text in a vm sandbox where ESM syntax and dynamic import() are unavailable (hexojs/hexo#5525), so each script is now a one-line CJS stub going through lib/esm-bridge.cjs, which lives outside the vm and can import() the real module. The stubs and the bridge can be deleted once hexo loads ESM scripts natively (hexojs/hexo#5820). Rendered output is unchanged (verified: data-zoom-src rewriting, post_link anchors, xkcd_infos payload, open-sidebar links all present in the generated site; no script load errors). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Aetf
added a commit
to Aetf/hexo-next-publist
that referenced
this pull request
Aug 21, 2026
Switch the package to type: module. Hexo cannot load an ESM plugin entry yet (it wraps the entry file text in an async vm function, see hexojs/hexo#5820), so main now points at a two-level CJS shim: index.cjs runs inside the vm and defers to bridge.cjs via the real require; bridge.cjs then dynamic-imports the ESM src/index.js. Both shims can be dropped once hexo supports ESM entries natively. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds native ES module plugin loading for
.mjsentries and.jsentries in packages with"type": "module".ES module plugins export a default initializer that receives the Hexo instance:
The existing CommonJS
vmloading path remains unchanged.Closes #5525.
Validation:
19 passing).Screenshots
Not applicable.
Pull request tasks