Skip to content

feat: warn on deprecated or unconfigured lb type - #1313

Merged
lukasmetzner merged 7 commits into
mainfrom
feat/warn-deprecated-lb-type
Aug 17, 2026
Merged

feat: warn on deprecated or unconfigured lb type#1313
lukasmetzner merged 7 commits into
mainfrom
feat/warn-deprecated-lb-type

Conversation

@lukasmetzner

@lukasmetzner lukasmetzner commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This PR adds a warning log message and event, if a Load Balancer Type is deprecated. If the Load Balancer Type is unavailable an error message is returned.

This PR adds a warning log message and event, if a Load Balancer Type is not configured by a user through the annotation or a cluster-wide default via environment variables.

Load Balancer Types are cached using our generic cache built for instances.

feat(load-balancer): warn on deprecated Load Balancer Type
feat(load-balancer): warn on unconfigured Load Balancer Type

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.82927% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.67%. Comparing base (18e0434) to head (c6f741a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/hcops/load_balancer.go 63.82% 11 Missing and 6 partials ⚠️
internal/hcops/testing.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
+ Coverage   71.28%   71.67%   +0.38%     
==========================================
  Files          27       29       +2     
  Lines        2807     2877      +70     
==========================================
+ Hits         2001     2062      +61     
- Misses        622      629       +7     
- Partials      184      186       +2     
Flag Coverage Δ
e2e 45.58% <51.21%> (+0.77%) ⬆️
unit 67.63% <71.95%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/hcops/load_balancer.go Outdated
Comment thread hcloud/cloud.go
@lukasmetzner
lukasmetzner force-pushed the feat/warn-deprecated-lb-type branch from 7dd9023 to e999c35 Compare August 17, 2026 06:16
lukasmetzner added a commit that referenced this pull request Aug 17, 2026
Allows adding caches for different hcloud resources.

See #1313
@lukasmetzner
lukasmetzner marked this pull request as ready for review August 17, 2026 07:29
@lukasmetzner
lukasmetzner requested a review from a team as a code owner August 17, 2026 07:29
Comment thread internal/cache/lbtypecache.go
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
@lukasmetzner
lukasmetzner merged commit b16f780 into main Aug 17, 2026
9 of 10 checks passed
@lukasmetzner
lukasmetzner deleted the feat/warn-deprecated-lb-type branch August 17, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants