feat: warn on deprecated or unconfigured lb type - #1313
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
==========================================
+ Coverage 71.28% 71.67% +0.38%
==========================================
Files 27 29 +2
Lines 2807 2877 +70
==========================================
+ Hits 2001 2062 +61
- Misses 622 629 +7
- Partials 184 186 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jooola
reviewed
Aug 14, 2026
lukasmetzner
force-pushed
the
feat/warn-deprecated-lb-type
branch
from
August 17, 2026 06:16
7dd9023 to
e999c35
Compare
lukasmetzner
added a commit
that referenced
this pull request
Aug 17, 2026
Allows adding caches for different hcloud resources. See #1313
lukasmetzner
force-pushed
the
feat/warn-deprecated-lb-type
branch
from
August 17, 2026 07:20
e999c35 to
81ea7e5
Compare
jooola
reviewed
Aug 17, 2026
jooola
approved these changes
Aug 17, 2026
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a warning log message and event, if a Load Balancer Type is deprecated. If the Load Balancer Type is unavailable an error message is returned.
This PR adds a warning log message and event, if a Load Balancer Type is not configured by a user through the annotation or a cluster-wide default via environment variables.
Load Balancer Types are cached using our generic cache built for instances.