Skip to content

fix: use HEROKU_CLI_CHANNEL in Direwolf test trigger#3765

Merged
michaelmalave merged 1 commit into
mainfrom
mm/fix/heroku-cli-channel-version
Jun 12, 2026
Merged

fix: use HEROKU_CLI_CHANNEL in Direwolf test trigger#3765
michaelmalave merged 1 commit into
mainfrom
mm/fix/heroku-cli-channel-version

Conversation

@michaelmalave

Copy link
Copy Markdown
Contributor

Summary

Fix the Direwolf test trigger to pass the release channel via HEROKU_CLI_CHANNEL instead of HEROKU_CLI_VERSION. The workflow has always passed a channel name (e.g. alpha), but the env var name HEROKU_CLI_VERSION caused the Direwolf test helper to treat it as a semver and run heroku update --version alpha`, which fails and skips all tests.

  • Replace HEROKU_CLI_VERSION with HEROKU_CLI_CHANNEL in the workflow env and runner script
  • Update the Direwolf API payload JSON key from HEROKU_CLI_VERSION to HEROKU_CLI_CHANNEL

Type of Change

  • fix: Bug fix or issue (patch semvar update)
  • feat: Introduces a new feature to the codebase (minor semvar update)
  • perf: Performance improvement
  • docs: Documentation only changes
  • tests: Adding missing tests or correcting existing tests
  • chore: Code cleanup tasks, dependency updates, or other changes

Verification

CI Passes

Additional Context

  • Breaking: none
  • Risk: low; variable-name alignment only
  • Follow-up: verify the downstream Direwolf suite expects HEROKU_CLI_CHANNEL (and not the old key) in production runs

Related Issue

GUS work item: W-22934969

…(defaulting to stable) instead of HEROKU_CLI_VERSION, keeping release-channel propagation consistent across the CI trigger payload
@michaelmalave michaelmalave requested a review from a team as a code owner June 12, 2026 22:57

@tlowrimore-heroku tlowrimore-heroku left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelmalave michaelmalave merged commit 62be38b into main Jun 12, 2026
18 checks passed
@michaelmalave michaelmalave deleted the mm/fix/heroku-cli-channel-version branch June 12, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants