fix: use HEROKU_CLI_CHANNEL in Direwolf test trigger#3765
Merged
Conversation
…(defaulting to stable) instead of HEROKU_CLI_VERSION, keeping release-channel propagation consistent across the CI trigger payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Direwolf test trigger to pass the release channel via
HEROKU_CLI_CHANNELinstead ofHEROKU_CLI_VERSION. The workflow has always passed a channel name (e.g.alpha), but the env var nameHEROKU_CLI_VERSIONcaused the Direwolf test helper to treat it as a semver and runheroku update --versionalpha`, which fails and skips all tests.HEROKU_CLI_VERSIONwithHEROKU_CLI_CHANNELin the workflow env and runner scriptHEROKU_CLI_VERSIONtoHEROKU_CLI_CHANNELType of Change
Verification
CI Passes
Additional Context
HEROKU_CLI_CHANNEL(and not the old key) in production runsRelated Issue
GUS work item: W-22934969