WIP: Prepare to v3.0.0 — drop Node <24, remove Yarn/Lerna, modernize tooling - #541
Open
OleksiiZubko wants to merge 3 commits into
Open
WIP: Prepare to v3.0.0 — drop Node <24, remove Yarn/Lerna, modernize tooling#541OleksiiZubko wants to merge 3 commits into
OleksiiZubko wants to merge 3 commits into
Conversation
OleksiiZubko
force-pushed
the
version_3
branch
2 times, most recently
from
July 28, 2026 06:54
b499287 to
f7fb716
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
=================================================
- Coverage 90.1118% 43.5596% -46.5522%
=================================================
Files 82 85 +3
Lines 2953 6956 +4003
Branches 333 324 -9
=================================================
+ Hits 2661 3030 +369
- Misses 136 3926 +3790
+ Partials 156 0 -156 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OleksiiZubko
force-pushed
the
version_3
branch
4 times, most recently
from
July 28, 2026 07:40
f7fb716 to
dd8888d
Compare
Migrate the monorepo tooling. Relates-To: MAJOR Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
olp-sdk-authentication pulled properties-reader in only to read two keys out of credentials.properties. The library brought @kwsites/file-exists and mkdirp along, the latter for writing .properties files, which the SDK never does. Replace it with a small local reader. It skips blank lines and `#` / `!` comments and splits on the first `=` or `:`, so base64 padding inside a secret survives parsing. The public API and the error message are unchanged. The package is left with no third-party dependencies at all, removing three packages from every consumer's tree. The matching @types/properties-reader dev dependency goes away with it. Relates-To: MINOR Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
requestToken_common rejected with the status text alone, so the response body was dropped. That body holds the correlationId and the description of the failure, which is exactly what is needed to trace a rejected token request with platform support. Read the body and append it to the HttpError message, in the format DataStoreDownloadManager already uses. The status text stays the whole message when the body is empty, and it is the fallback when reading the body fails, so a broken stream never masks the HTTP error itself. Over HTTP/2 the status text is empty, in which case the body alone is reported. Relates-To: HERESUP-71374 Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the monorepo tooling for the 3.0.0 release:
Relates-To: MAJOR