Skip to content

build: upgrade dependencies and migrate to Pest v5 - #493

Merged
danielhe4rt merged 4 commits into
4.xfrom
chore/deps-upgrade-and-pest-v5-migration
Aug 15, 2026
Merged

build: upgrade dependencies and migrate to Pest v5#493
danielhe4rt merged 4 commits into
4.xfrom
chore/deps-upgrade-and-pest-v5-migration

Conversation

@gvieira18

@gvieira18 gvieira18 commented Aug 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Migrate test suite from Pest 4 to Pest v5 (and swap mrpunyapal/rector-pest for the official pestphp/pest-plugin-rector).
  • Drop the custom App\Support\PestShardPlugin: Pest v5 generalized shard discovery upstream, so modular tests (Appmodules\<module>\tests\...) are no longer silently excluded from shards. Removed its composer registration, PHPStan exclude, and Rector skip.
  • Tune Rector: ChainExpectCallsRector with merge_different_variables => false (chains same-value expects, does not force ->and() across different values); skip the Pest 2→3 UsesToExtendRector; enable withPhpSets(php84: true).
  • Bump composer deps (Laravel 13.25, Filament 5.7.6, Nightwatch, Telescope, Flux, spatie, etc.) and npm dev deps.
  • Switch Vite minifier from terser to oxc (terser dropped from npm deps).

Test plan

  • composer check (Rector dry-run + Pint + PHPStan) passes
  • vendor/bin/pest --shard=1/2 + --shard=2/2 run sequentially; sum of files ran equals total (no orphaned tests)
  • Full suite green: php artisan test --compact

Swap mrpunyapal/rector-pest for the official pestphp/pest-plugin-rector
and bump the framework/tooling deps. Drops the custom PestShardPlugin —
Pest v5 generalized shard discovery upstream, so modular tests are no
longer excluded from shards. Tune ChainExpectCallsRector to not merge
different variables via ->and().
@gvieira18
gvieira18 requested a review from a team August 15, 2026 18:19
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 1fa8744e-ab3e-4230-8216-4a16920b90a5

📥 Commits

Reviewing files that changed from the base of the PR and between bd5cd67 and 10f237e.

⛔ Files ignored due to path filters (2)
  • composer.lock is excluded by !**/*.lock
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (7)
  • app-modules/events/tests/Feature/EventFactoriesTest.php
  • app/Support/PestShardPlugin.php
  • composer.json
  • package.json
  • phpstan.neon
  • rector.php
  • vite.config.js
💤 Files with no reviewable changes (2)
  • phpstan.neon
  • app/Support/PestShardPlugin.php

📝 Walkthrough

Walkthrough

The pull request removes the custom Pest sharding plugin and its configuration. It updates Composer and npm dependency constraints. Rector configuration now targets newer Pest and PHP rules. Vite uses Oxc instead of Terser for minification. The QR token test uses Pest’s toHaveLength(64) matcher.

Possibly related PRs

Suggested reviewers: danielhe4rt

Merge Risk: ⚪ Minimal · up to 10f23

This change updates dependencies and testing/build tooling without any supplied actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary dependency upgrade and migration from Pest 4 to Pest 5.
Description check ✅ Passed The description explains the migration, dependency changes, removed shard plugin, configuration updates, and completed test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danielhe4rt
danielhe4rt merged commit 7656c53 into 4.x Aug 15, 2026
10 checks passed
@danielhe4rt
danielhe4rt deleted the chore/deps-upgrade-and-pest-v5-migration branch August 15, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants