build: upgrade dependencies and migrate to Pest v5 - #493
Conversation
Swap mrpunyapal/rector-pest for the official pestphp/pest-plugin-rector and bump the framework/tooling deps. Drops the custom PestShardPlugin — Pest v5 generalized shard discovery upstream, so modular tests are no longer excluded from shards. Tune ChainExpectCallsRector to not merge different variables via ->and().
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe pull request removes the custom Pest sharding plugin and its configuration. It updates Composer and npm dependency constraints. Rector configuration now targets newer Pest and PHP rules. Vite uses Oxc instead of Terser for minification. The QR token test uses Pest’s Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change updates dependencies and testing/build tooling without any supplied actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
mrpunyapal/rector-pestfor the officialpestphp/pest-plugin-rector).App\Support\PestShardPlugin: Pest v5 generalized shard discovery upstream, so modular tests (Appmodules\<module>\tests\...) are no longer silently excluded from shards. Removed its composer registration, PHPStan exclude, and Rector skip.ChainExpectCallsRectorwithmerge_different_variables => false(chains same-value expects, does not force->and()across different values); skip the Pest 2→3UsesToExtendRector; enablewithPhpSets(php84: true).tersertooxc(terser dropped from npm deps).Test plan
composer check(Rector dry-run + Pint + PHPStan) passesvendor/bin/pest --shard=1/2+--shard=2/2run sequentially; sum of files ran equals total (no orphaned tests)php artisan test --compact