Repository navigation
build: bump engine to e2ca4b1 - #5
Merged
Merged
Conversation
e2ca4b1 feat(rendering): make CharacterView public to draw the character without a board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps puzzle-boy on the same engine as Community Edition, whose Classic title now draws the Jack-o'-Lantern on its own.
The engine change is one line:
CharacterViewgoes frominternaltopublic(plus a test and a ROADMAP note). puzzle-boy never namesCharacterView;BoardViewdraws it exactly as before, so nothing the game shows or does changes.Gates on this branch: build (0 warnings), 23 tests, format, and the no-game-data guard and its positive control.