Repository navigation
Use the shared original UI code - #4
Merged
Merged
Conversation
- 842ed69 refactor: move the original HUD, menus and text into PuzzleBoy.Rendering - 49a07d8 docs: record the shared original UI as E4
Hud, TextRenderer, Menu and Dialogue now come from the engine's PuzzleBoy.Rendering, so this port's copies and their tests (28 cases) go. GameAssets imports PuzzleBoy.Rendering for UiSheets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the code that draws the original's interface into the engine, the same way M6 moved the board renderer, so Community Edition's Classic theme can draw the original HUD, controls bar, menu, help and text with this port's code. Nothing about what this port shows, or when, changes.
What moved
To the engine's
PuzzleBoy.Rendering(engine842ed69, pinned here at49a07d8):Hud.cs:Hud,UiLayout,UiSheets,HudState,BarSetTextRenderer.cs:TextRenderer,BakedTextMenu.cs:Menu,MenuItem,KeyRepeatDialogue.cs:Dialogue, becauseHud.DrawDialoguetakes one. When the Manikin Kid talks stays inPuzzleBoyGame.PuzzleBoyGame,GameAssets,OriginalStageOrderandProgramstay here.GameAssets.csgainsusing PuzzleBoy.Rendering;forUiSheets.Fidelity evidence
Each moved file diffed against
83c9565(main before the move): 8 files, 1,081 lines. 19 lines changed and 1 removed:namespacelines (PuzzleBoytoPuzzleBoy.Rendering, tests toPuzzleBoy.Rendering.Tests)internaltopublicHud.csdropsusing PuzzleBoy.Rendering;, which is now its own namespaceNo citation, statement, constant or expression changed.
PuzzleBoy no-game-hereprints the same missing-game message. Not checked: a screen drawn from a real install.Tests
28 cases moved: Hud 10, TextRenderer 10, Menu 4, Dialogue 4.
ControlsTestsstays whole, since every case readsPuzzleBoyGame's key tables. None lost.Commits
build: bump engine to 49a07d8, which builds and passes all 51 tests before the deletionsrefactor: use the shared HUD, menus and textdocs: record the shared original UI as M7: ROADMAP M7 and ledger, AGENTS.md layout, docs/architecture.mdEngine CI passed at
842ed69(run 38777842184) and49a07d8(run 38778313341).