ETT-1679: move class name to fix matomo script load - #244
Open
carylwyatt wants to merge 2 commits into
Open
Conversation
eumalin
reviewed
Jul 29, 2026
| </head> | ||
|
|
||
| <body style="opacity: 0;"> | ||
| <body class="apps" style="opacity: 0;"> |
Contributor
There was a problem hiding this comment.
Moving the class to body makes sense for Matomo. One thing: ssd/web/ssdstyles.css line 14 targets #mdpUberContainer.apps, and that element loses the apps class here, so the rule stops applying and the container loses its left margin. Could we change it to #mdpUberContainer instead?
carylwyatt
force-pushed
the
ETT-1679-ssd-matomo
branch
from
July 30, 2026 17:50
1589f8d to
f4b16ad
Compare
Member
Author
|
@eumalin I removed the |
eumalin
approved these changes
Jul 30, 2026
eumalin
left a comment
eumalin
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for addressing the comment!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's not really anything to test here, just need a second set of eyes on this.
I tried to test this in matomo's preview mode but couldn't find the
customUrlset in the data layer. But! When I found myself in the logs, you can see the altered/custom url in the pageview history. SSD url paths are like/cgi/ssd/id?=umn....but the url has been rewritten with the path as/ssd/umn...which is a closer match for how we track pt pageviews in matomo.