Fix DWC2 DMA data toggle mismatch in IN-transfers - #3872
Open
runelauridsen wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Collaborator
|
Thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the DWC2 driver, when an IN transfer completes in non-DMA mode, the driver correctly reads the updated
pidand saves it tonext_pid:However, the handler for DMA mode (
handle_channel_in_dma) was missing this logic. If the expected number of packets was not received, then for all subsequent transfers the driver would program the wrong DATA0/DATA1 pid for their initial packets.With this patch the DMA handler now matches the non-DMA handler.
The issue was observed when interfacing with a LAN9500. After some time, ethernet frames would start missing their first 64 bytes, because the first USB packet in each transfer was discarded due to the DATA0/DATA1 mismatch.