Conversation
There was a problem hiding this comment.
LGTM. lukko does not seem to get upgraded to GHC 9.14, so it makes sense to drop it.
| base-compat >= 0.12.2 | ||
|
|
||
| constraint-set no-lukko | ||
| constraints: hackage-security -lukko |
There was a problem hiding this comment.
That was probably the wrong way round: since lukko was off by default, this constraint-set did not test anything (I suppose the intention was to actually test lukko). This explains why CI on GHC 9.14 did not fail despite lukko not being available.
|
@Bodigrim Do you have rights to merge this? |
|
@andreasabel technically I'm able to merge, but won't be able to make a release anyway. |
|
@Mikolaj @andreasabel how do we make progress on this? |
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
Let's merge. Thank you for carrying it through, @Bodigrim.
Cabal 3.18 release process is about to begin and one of the release checklist points is a new hackage-security release, if needed/reasonable, so maybe let's release after we make sure all deps bumps induced by the new cabal are in. CC @ulysses4ever.
3 participants
A year ago we stopped using
lukkopackage by default and guarded it by a Cabal flag. No one complained and I never heard of anyone forcing the Cabal flag to uselukkoinstead ofbase. I think it's time we clean it up entirely.