fix: [CCM-34691]: Redact sensitive HTTP/RPC header values in span attributes#16
Open
suryanarayanan-venkatesan wants to merge 1 commit into
Conversation
BaseInstrumentorWrapper.add_headers_to_span() wrote every captured header value onto the span verbatim. Because the OpenAI/Anthropic SDKs make their API calls over httpx, the HTTP instrumentation fired alongside the GenAI instrumentation and exported the provider credential (Authorization: Bearer sk-..., x-api-key: sk-ant-...) into telemetry. Add a default denylist of credential-bearing headers (authorization, proxy-authorization, x-api-key, api-key, apikey, x-auth-token, x-amz-security-token, x-goog-api-key, cookie, set-cookie, x-harness-service-token, x-harness-token) and replace their values with [REDACTED] in the single choke point used by both the HTTP (requests/httpx/aiohttp) and RPC (gRPC) handlers. Matching is case-insensitive; benign header values are unchanged. Adds unit tests covering redaction, case-insensitivity, and pass-through. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
|
suryanarayanan-venkatesan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseInstrumentorWrapper.add_headers_to_span() wrote every captured header value onto the span verbatim. Because the OpenAI/Anthropic SDKs make their API calls over httpx, the HTTP instrumentation fired alongside the GenAI instrumentation and exported the provider credential (Authorization: Bearer sk-..., x-api-key: sk-ant-...) into telemetry.
Add a default denylist of credential-bearing headers (authorization, proxy-authorization, x-api-key, api-key, apikey, x-auth-token, x-amz-security-token, x-goog-api-key, cookie, set-cookie, x-harness-service-token, x-harness-token) and replace their values with [REDACTED] in the single choke point used by both the HTTP (requests/httpx/aiohttp) and RPC (gRPC) handlers. Matching is case-insensitive; benign header values are unchanged.
Adds unit tests covering redaction, case-insensitivity, and pass-through.