Conversation
- added `SetIter` return - fixed callable in `_buffer` - `tuple` in _set`
Author
|
If it's preferred, I can switch this to a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
While working around with
fonttoolsand such, the lack of proper type annotations forharfbuzzstarted driving me a bit crazy. I tried running it manually in my repos, but I noticed it had type issues upstream, so I wrote this PR.Changes
stubgen-pyxusage, insetup.pySet[int]to justSet- checked bymypyMutableSet[Int]but that was quite troublesome;Setnow returnsSetIterproperlyhb_color_line_tinsrc/uharfbuzz/charfbuzz.pxduv.lockto ignores, alongsidepyiand.typedmypydetectionIssues
stubgen-pyxis a hit behind, so the use ofcython 3.3.0isn't quite here yet.LLM Disclosure
All work was done by me, but I had Gemini/AGY double check things for me.