✨ feat(mq-repl): complete string literals from loaded document structure - #2223
Merged
Conversation
Offer heading text, YAML/TOML frontmatter keys, and dict keys found in
the currently loaded input as completions inside string literals (e.g.
select(to_string() == "..." or get("...")), instead of only static
builtins/selectors.
…ndex Consolidate the heading/frontmatter-key/dict-key completion caches, which are always rebuilt together, into a single DocumentIndex struct built up-front (mirroring how hir is constructed) instead of three loose fields mutated in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Offer heading text, YAML/TOML frontmatter keys, and dict keys found in the currently loaded input as completions inside string literals (e.g. select(to_string() == "..." or get("...")), instead of only static builtins/selectors.
Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context