Repository navigation
Send macOS editing commands for Chromium keyboard shortcuts - #87
Merged
Merged
Conversation
Chromium does not run native key bindings for synthetic key events on macOS, so Meta+A, copy/paste, undo/redo and similar shortcuts did nothing. Upstream crInput sends the matching macEditingCommands in Input.dispatchKeyEvent when the browser runs on a Mac. Do the same, and share the existing WebKit command table and shortcut builder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, Chromium keyboard shortcuts like Meta+A, copy, cut, paste, undo and redo did nothing. Chromium does not run the native key bindings for synthetic key events, so six PageKeyboardTests failed on a Mac. Upstream solves this by sending the matching macOS editing commands in the
commandsfield ofInput.dispatchKeyEvent, and we now do the same.The commands go out only when the browser user agent says Macintosh, exactly like upstream, so Linux and Windows are unchanged. The command table already existed for WebKit; it now lives in
Input/so both keyboards share it and the shortcut builder.🤖 Generated with Claude Code