Repository navigation
fix(pcan): preserve Linux epoch timestamps without boot offset - #2119
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5 of 10 tasks
Author
|
@codex review
Retrying the automated review that could not complete on the unchanged PR
head.
On Mon, 26 Oct 2026 21:58:55 -0700, "chatgpt-codex-connector[bot]" < ***@***.***> wrote:
chatgpt-codex-connector[bot] left a comment (hardbyte/python-can#2119) <!--
codex-pull-request-review-summary --> <!-- codex-review-state:v1
{"code_review":{"commit_sha":"6bf8c074a6ba919d5c9b5833c9386be74c479690","has_any_findings":null,"has_unresolved_findings":null,"status":"running"},"security_review":{"commit_sha":null,"has_any_findings":null,"has_unresolved_findings":null,"status":null}}
--> ## Codex Review Summary This comment shows the latest Codex review
activity on this pull request. | Review | Status | Commit | Review trigger
| | --- | --- | --- | --- | | 📝 **Code Review** | 🔄 **Running** since
<relative-time
datetime="2026-10-27T04:58:29.400879Z">2026-10-27T04:58:29.400879Z</relative-time>
| `6bf8c07` | PR opened | <details> <summary>ℹ️ About Codex in
GitHub</summary> <br/> [Your team has set up Codex to review pull requests
in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews
are triggered when you - Open a pull request for review - Mark a draft as
ready - Comment ***@***.*** review" or ***@***.*** security review". Codex reacts
with 👀 while any review is running, comments if it has suggestions, and
reacts with 👍 once all reviews finish with no findings. </details> --
Reply to this email directly or view it on GitHub:
#2119 (comment)
You are receiving this because you authored the thread. Message ID:
***@***.***>
|
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Preserve PCAN-Basic's Linux Unix-epoch timestamps for classic CAN and CAN FD. Select a zero boot offset on Linux, bypassing the irrelevant uptime import/lookup/warning; retain the complete existing conversion and fallback on other platforms. Add platform/clock controls, documentation and a news fragment.
Related Issues / Pull Requests
Closes #2108. Thanks to @rodrigocarbonell-creator for the report and clock-domain diagnosis. PEAK's timestamp documentation distinguishes Windows system-start timestamps from Linux epoch timestamps. The original preparation also inspected the Linux 5.0.1.8 source/addendum; no vendor code is redistributed. Current #1901 changes bus-state names, not this clock conversion.
Type of Change
Checklist
Additional Notes
Validation recorded on 25 October 2026, CPython 3.13.16 / Linux:
On 27 October, public head
6bf8c074a6ba919d5c9b5833c9386be74c479690, treed5825a6c0228039dff16561b4178409eea9fb114, was restored exactly from clean tested19b565f877c76fbc2853aa3dc2814b0b1dd4b399on unchanged mainb4f82ab. Original/refresh archive hashes, raw XML, source identities and independent review were checked. Tests were not rerun during publication.No physical PCAN adapter/driver execution, native Windows/macOS, SocketCAN vcan or complete interpreter matrix is validated. This preserves existing non-Linux semantics; it does not newly establish those platforms' hardware clock behavior.
Prepared with AI assistance and independent inspection.
Timothy Anderson — Spotted Ridge Engineering / OC Labs
Independent software verification · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence