fix(socketcan): support socket file descriptors over 1023#2057
Open
SAY-5 wants to merge 3 commits into
Open
Conversation
select.select() is limited by glibc's FD_SETSIZE (1024) and raises ValueError for higher fds even when the OS limit allows them. Switch SocketcanBus._recv_internal() and send() to select.poll(), which has no such limit. Fixes hardbyte#2053. Signed-off-by: SAY-5 <say.apm35@gmail.com>
Signed-off-by: SAY-5 <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix/socketcan-high-fd
branch
from
5d2dca1 to
43dc1a5
Compare
zariiii9003
reviewed
Jun 6, 2026
| while time_left >= 0: | ||
| # Wait for write availability | ||
| ready = select.select([], [self.socket], [], time_left)[1] | ||
| ready = poller.poll(max(0, int(time_left * 1000))) |
Collaborator
There was a problem hiding this comment.
What's the max call for? time_left is alwas positive here.
zariiii9003
reviewed
Jun 6, 2026
| # being self.socket or an empty list if self.socket is not ready) | ||
| ready_receive_sockets, _, _ = select.select([self.socket], [], [], timeout) | ||
| # poll() avoids select.select()'s ValueError for fds >= FD_SETSIZE | ||
| poller = select.poll() |
Collaborator
There was a problem hiding this comment.
You create new poll objects on every read and write. That can't be good for performance.
Create one poll object inside __init__() and register both POLLIN and POLLOUT. Then here you call (fd, event) = self._poller.poll() and check whether the event contains POLLIN.
zariiii9003
reviewed
Jun 6, 2026
| @@ -0,0 +1,91 @@ | |||
| #!/usr/bin/env python | |||
Collaborator
There was a problem hiding this comment.
You don't need to create a new file to test this. Add a test to the existing socketcan tests.
zariiii9003
reviewed
Jun 6, 2026
| @@ -0,0 +1 @@ | |||
| ``SocketcanBus`` now uses ``select.poll()`` instead of ``select.select()`` so that socket file descriptors above ``FD_SETSIZE`` (1024 on glibc) no longer raise ``ValueError: filedescriptor out of range in select()``. | |||
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
SocketcanBus._recv_internal()andsend()fromselect.select()toselect.poll().test/test_socketcan_high_fd.py(Linux-only) covering send/recv with a mocked socket whose fd is 2048.Related Issues / Pull Requests
SocketcanBusdoes not support socket file descriptors over 1023 #2053Type of Change
Checklist
tox).Additional Notes
select.select()is limited by glibc'sFD_SETSIZE(1024) and raisesValueError: filedescriptor out of range in select()for higher fds even when the OS limit allows them.select.poll()has no such limit and returns equivalent readiness data. The change is internal toSocketcanBus; the public send/recv signatures and exception semantics are unchanged.