fix namespace issue in RubyFileGenerator#436
Merged
Merged
Conversation
mddelk
marked this pull request as ready for review
July 12, 2026 05:38
mddelk
force-pushed
the
fix-app-namespace-name-conflict
branch
from
July 12, 2026 16:16
d5a09d4 to
a0655a0
Compare
mddelk
force-pushed
the
fix-app-namespace-name-conflict
branch
from
July 12, 2026 16:53
a0655a0 to
61341af
Compare
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
Since the namespace conflict avoidance is a common feature across all generators, focus on testing this in unit tests primarily. Leave just one integration test, which we reference from the unit tests so it’s easy to find.
timriley
force-pushed
the
fix-app-namespace-name-conflict
branch
from
July 18, 2026 12:52
f6e9a89 to
b242eb6
Compare
Member
|
Thank you @mddelk, this is great!! I've just made a few tweaks (see commits above). The biggest change was removing some of the testing redundancy — for shared behaviour like this I'm trying to set a pattern where we focus more on unit tests and use a smaller set of integration tests to ensure things are exercised as expected. Merging now! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
RubyFileGeneratorso that it properly handles nested namespaces that might conflict with the app or slice name.see https://discourse.hanakai.org/t/namespace-issue-when-generating-actions-that-match-the-app-name/1501