Repository navigation
Fix search modal focus restoration and refresh build configuration - #66
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the search modal with Escape or a backdrop click leaves keyboard focus on the document body. Restore focus to the element that opened it after the modal DOM updates, including triggers inside open shadow roots. Ignore Escape while the modal is closed.
To reproduce, focus a search trigger, press Enter to open the modal, then press Escape. Before this fix, focus moves to BODY; afterward, it returns to the trigger. Backdrop dismissal follows the same behavior.
Add Vitest Browser Mode tests using Playwright Chromium, covering repeated openings, multiple triggers, batched close/reopen, unavailable triggers, and same-document result navigation.
Update the plugin platform dependency from 2.17.0-SNAPSHOT to 2.20.11 and simplify Gradle repositories to Maven Central and Gradle Plugin Portal.
Validation:
pnpm test../gradlew build --no-daemon --max-workers=1passed with Java 17. There are no Java test sources.NoSuchFieldError: JCTree$JCImport.qualid; Java 21 compatibility is not addressed by this PR.Fixes #65